Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[i18n] EUI token use FormattedMessage instead of i18n.translate #105841

Merged
merged 1 commit into from
Jul 16, 2021
Merged

[i18n] EUI token use FormattedMessage instead of i18n.translate #105841

merged 1 commit into from
Jul 16, 2021

Conversation

thompsongl
Copy link
Contributor

Summary

Updates an i18n token added in #105127 to use FormattedMessage instead of i18n.translate. The pagination numbers are React components, not strings, and were therefore rendering as [object Object].

@thompsongl thompsongl requested review from a team as code owners July 15, 2021 20:08
@thompsongl thompsongl requested a review from nreese July 15, 2021 20:08
@thompsongl thompsongl added release_note:skip Skip the PR/issue when compiling release notes v7.15.0 v8.0.0 labels Jul 15, 2021
nreese
nreese approved these changes Jul 15, 2021
View reviewed changes
Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for fixing
code review and tested in chrome.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 421.5KB 421.6KB +59.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

TinaHeiligers
TinaHeiligers approved these changes Jul 15, 2021
View reviewed changes
Copy link
Contributor

@TinaHeiligers TinaHeiligers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thompsongl thompsongl added the auto-backport Deprecated - use backport:version if exact versions are needed label Jul 16, 2021
@thompsongl thompsongl merged commit 2af1d59 into elastic:master Jul 16, 2021
@kibanamachine kibanamachine mentioned this pull request Jul 16, 2021
Closed
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 16, 2021
@thompsongl @kibanamachine
use FormattedMessage instead of i18n.translate (elastic#105841)
19e04fb
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

@thompsongl thompsongl mentioned this pull request Jul 16, 2021
Merged
thompsongl added a commit to thompsongl/kibana that referenced this pull request Jul 16, 2021
@thompsongl
use FormattedMessage instead of i18n.translate (elastic#105841)
92c6891
thompsongl added a commit that referenced this pull request Jul 16, 2021
@thompsongl
use FormattedMessage instead of i18n.translate (#105841) (#105965)
4463abf
thompsongl added a commit to thompsongl/kibana that referenced this pull request Jul 28, 2021
@thompsongl
reinstate elastic#105841
f6a6f28
@thompsongl thompsongl mentioned this pull request Jul 28, 2021
Merged
thompsongl added a commit that referenced this pull request Jul 29, 2021
@thompsongl @kibanamachine
reinstate #105841 (#107080)
c2cb189 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@thompsongl thompsongl mentioned this pull request Jul 29, 2021
Merged
thompsongl added a commit to thompsongl/kibana that referenced this pull request Jul 29, 2021
@thompsongl @kibanamachine
reinstate elastic#105841 (elastic#107080)
21fba00 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
thompsongl added a commit that referenced this pull request Jul 29, 2021
@thompsongl @kibanamachine
reinstate #105841 (#107080) (#107207)
ebc4ce5 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
streamich pushed a commit to vadimkibana/kibana that referenced this pull request Aug 8, 2021
@thompsongl @kibanamachine @vadimkibana
reinstate elastic#105841 (elastic#107080)
0b6e47b 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TinaHeiligers TinaHeiligers TinaHeiligers approved these changes

@nreese nreese nreese approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes v7.15.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thompsongl @kibanamachine @nreese @TinaHeiligers