-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[POC] multi-process Kibana with Node clustering #106055
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⏳ Build in-progress, with failures
Failed CI Steps
Test FailuresJest Tests.src/core/server/logging.uses default memory buffer logger until config is providedStandard Out
Stack Trace
Jest Tests.src/core/server/logging.flushes memory buffer logger and switches to real logger once config is providedStandard Out
Stack Trace
Jest Tests.src/core/server/logging.appends records via multiple appenders.Standard Out
Stack Trace
and 20 more failures, only showing the first 3. To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a POC of #68626, based on the final RFC #94057. It was forked from the original POC (#93380).
Main differences from the main POC include:
clustering
->node
In particular the logging implementation needs more thought. At the moment the logic is hacked into
BaseLogger
, with a conversion process that makes eachLogRecord
serializable. The conversion process has potential to negatively impact performance as it happens for every record; we may want to consider broader changes to theLogRecord
interface itself to avoid the need for it.Rather than hacking
BaseLogger
, it may be worth considering an internal "IPC appender" that handles making the record serializable and sending the IPC message for the coordinator.Also more thought needs to be put into how the coordinator handles augmenting each record with worker-specific information. This is where a logging MDC could potentially come in handy.