Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.x] [RAC] [TGrid] Field browser implemented in EuiDataGrid toolbar (#105207) #106278

Merged
merged 1 commit into from
Jul 20, 2021
Merged

[7.x] [RAC] [TGrid] Field browser implemented in EuiDataGrid toolbar (#105207) #106278

merged 1 commit into from
Jul 20, 2021

Conversation

kibanamachine
Copy link
Contributor

Backports the following commits to 7.x:

@semd @kibanamachine
[RAC] [TGrid] Field browser implemented in EuiDataGrid toolbar (elast…
04ee163 
…ic#105207)

* tGid header using EuiDataGrid

* useFetchIndex migrated and column_headers refactor

* removed useless mock

* add badges translations

* i18n translations keys fixed

* code format

* filter default columns not present in field browser

* reset button to initial columns

* cleaning

* dependencies moved

* fix functional test with missing data service

* remove unused code (unrelated)

* fieldBrowser integration with security solutions timeline

* lint and translations cleaned

* timeline toolbar removed for merge & some test fixes

* type fix

* type fixes

* timeline static default colums

* limit size temporary increase

* limit size temporary increase

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine enabled auto-merge (squash) July 20, 2021 15:55
@kibanamachine kibanamachine mentioned this pull request Jul 20, 2021
Merged
3 tasks
@kibanamachine
Copy link
Contributor Author

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 2208 2198 -10
timelines 223 246 +23
total +13

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
timelines 759 763 +4

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 6.3MB 6.2MB -50.0KB
timelines 261.4KB 234.1KB -27.3KB
total -77.4KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
timelines 23 25 +2

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
timelines 231.3KB 320.7KB +89.4KB
Unknown metric groups

API count

id before after diff
timelines 878 882 +4

async chunk count

id before after diff
timelines 3 4 +1

References to deprecated APIs

id before after diff
timelines 28 34 +6

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @semd

@kibanamachine kibanamachine merged commit a74a3a2 into elastic:7.x Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@semd semd

Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kibanamachine @semd