Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[l10n] remove a couple of unused translations #106977

Merged
merged 4 commits into from
Aug 3, 2021
Merged

[l10n] remove a couple of unused translations #106977

merged 4 commits into from
Aug 3, 2021

Conversation

Bamieh
Copy link
Member

@Bamieh Bamieh commented Jul 28, 2021

i18n message ids with a .markdown postfix are now used to explicitly mark that the message contains markdown syntax. This is used to help translators to translate the message correctly.

I was going over already existing ids with .markdown postfix and noticed those 2 ids are not used anywhere so instead of renaming them to .markdownTitle i removed them completely.

@Bamieh Bamieh added Project:i18n v8.0.0 release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v7.15.0 labels Jul 28, 2021
@Bamieh Bamieh marked this pull request as ready for review July 28, 2021 13:34
@Bamieh Bamieh requested review from a team as code owners July 28, 2021 13:34
@Bamieh
Copy link
Member Author

Bamieh commented Aug 2, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@Bamieh Bamieh merged commit 6d145c8 into master Aug 3, 2021
@Bamieh Bamieh deleted the i18n/remove_unused branch August 3, 2021 14:04
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Aug 3, 2021
@Bamieh @kibanamachine
[l10n] remove a couple of unused translations (elastic#106977)
2247640 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine mentioned this pull request Aug 3, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Aug 3, 2021
@kibanamachine @Bamieh
[l10n] remove a couple of unused translations (#106977) (#107529)
061bb51 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Ahmad Bamieh <ahmadbamieh@gmail.com>
streamich pushed a commit to vadimkibana/kibana that referenced this pull request Aug 8, 2021
@Bamieh @kibanamachine @vadimkibana
[l10n] remove a couple of unused translations (elastic#106977)
70184c1 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrew-goldstein andrew-goldstein andrew-goldstein approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Project:i18n release_note:skip Skip the PR/issue when compiling release notes v7.15.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Bamieh @kibanamachine @andrew-goldstein