Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security solution][Endpoint] Disallow list operator in event filters form #107122

Conversation

dasansol92
Copy link
Contributor

@dasansol92 dasansol92 commented Jul 29, 2021

Summary

As there is no support yet for this operator in the artifacts let's disallow this by now until we know if this is something we can add or not.
UPDATE: endpoint doesn't support this operator
Before:

Screenshot 2021-07-29 at 10 17 34

After:

disallow list operator

For maintainers

@dasansol92 dasansol92 added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v7.14.0 auto-backport Deprecated - use backport:version if exact versions are needed v7.15.0 labels Jul 29, 2021
@dasansol92 dasansol92 marked this pull request as ready for review July 30, 2021 08:20
@dasansol92 dasansol92 requested a review from a team as a code owner July 30, 2021 08:20
@dasansol92 dasansol92 requested review from pzl and paul-tavares July 30, 2021 08:20
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-onboarding-and-lifecycle-mgt (Team:Onboarding and Lifecycle Mgt)

@dasansol92
Copy link
Contributor Author

@elasticmachine merge upstream

@dasansol92
Copy link
Contributor Author

@elasticmachine merge upstream

@dasansol92
Copy link
Contributor Author

dasansol92 commented Aug 2, 2021

Hey @kertal, is there any reason to close this? I think maybe there is some wrong link between pr's

@dasansol92 dasansol92 reopened this Aug 2, 2021
@kertal
Copy link
Member

kertal commented Aug 2, 2021

@dasansol92 hey, sorry! seems the link was wrong! no reason to close this!

@dasansol92
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@paul-tavares paul-tavares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 🔥 😆

@dasansol92 dasansol92 merged commit ec4de0d into elastic:master Aug 4, 2021
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Aug 4, 2021
… form (elastic#107122)

* adds entries.list.id field in the searchable event filters fields list

* adds test case for list.id operator

* Revert "adds entries.list.id field in the searchable event filters fields list"

This reverts commit 45a66fd.

* Revert "adds test case for list.id operator"

This reverts commit 9dba145.

* Disable large value list option in operators dropdown

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Aug 4, 2021
… form (#107122) (#107645)

* adds entries.list.id field in the searchable event filters fields list

* adds test case for list.id operator

* Revert "adds entries.list.id field in the searchable event filters fields list"

This reverts commit 45a66fd.

* Revert "adds test case for list.id operator"

This reverts commit 9dba145.

* Disable large value list option in operators dropdown

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: David Sánchez <davidsansol92@gmail.com>
streamich pushed a commit to vadimkibana/kibana that referenced this pull request Aug 8, 2021
… form (elastic#107122)

* adds entries.list.id field in the searchable event filters fields list

* adds test case for list.id operator

* Revert "adds entries.list.id field in the searchable event filters fields list"

This reverts commit 45a66fd.

* Revert "adds test case for list.id operator"

This reverts commit 9dba145.

* Disable large value list option in operators dropdown

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v7.15.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants