Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove core dependency on data plugin #107259

Merged
merged 2 commits into from
Aug 2, 2021
Merged

remove core dependency on data plugin #107259

merged 2 commits into from
Aug 2, 2021

Conversation

mshustov
Copy link
Contributor

Summary

Closes #55485

@mshustov mshustov added chore Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.15.0 labels Jul 30, 2021
@mshustov mshustov requested a review from a team as a code owner July 30, 2021 06:09
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@mshustov
Copy link
Contributor Author

mshustov commented Aug 1, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

afharo
afharo approved these changes Aug 2, 2021
View reviewed changes
Copy link
Member

@afharo afharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mshustov mshustov added the auto-backport Deprecated - use backport:version if exact versions are needed label Aug 2, 2021
@mshustov mshustov merged commit 169d75f into elastic:master Aug 2, 2021
@mshustov mshustov deleted the remove-core-deps-on-data branch August 2, 2021 15:44
@kibanamachine kibanamachine mentioned this pull request Aug 2, 2021
Merged
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Aug 2, 2021
@mshustov @kibanamachine
remove core dependency on data plugin (elastic#107259)
ab7c301 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Aug 2, 2021
@kibanamachine @mshustov
remove core dependency on data plugin (#107259) (#107408)
b0d4b89 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Mikhail Shustov <restrry@gmail.com>
streamich pushed a commit to vadimkibana/kibana that referenced this pull request Aug 8, 2021
@mshustov @kibanamachine @vadimkibana
remove core dependency on data plugin (elastic#107259)
7d4e3e2 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afharo afharo afharo approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed chore release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.15.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[core.savedObjects] Update esKuery imports to pull from new package instead of data plugin
4 participants
@mshustov @elasticmachine @kibanamachine @afharo