[APM] Share components across Service overview and transactions. Add time comparison to the Transactions page #107299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cauemarcondes
added
release_note:enhancement
auto-backport
|
@elasticmachine merge upstream |
|
Pinging @elastic/apm-ui (Team:apm) |
…marcondes/kibana into apm-transaction-overview-comparison
formgeist
approved these changes
Aug 2, 2021
It'll definitely be faster now, since it uses the same API and the result is cached. |
|
I wish all PRs looked like this |
sorenlouv
reviewed
Aug 2, 2021
...ins/apm/public/components/app/service_overview/service_overview_transactions_table/index.tsx
Outdated
Show resolved
Hide resolved
sorenlouv
reviewed
Aug 2, 2021
| @@ -94,137 +169,47 @@ function getItemsWithRelativeImpact( | |||
| item.sum !== null && item.sum !== undefined | |||
| ? ((item.sum - min) / (max - min)) * 100 || 0 | |||
| : 0, | |||
| p95: item.p95, | |||
There was a problem hiding this comment.
no, the current table doesn't have it. #91848 (comment)
sorenlouv
approved these changes
Aug 2, 2021
smith
reviewed
Aug 3, 2021
| <TransactionList | ||
| isLoading={transactionListStatus === 'loading'} | ||
| items={transactionListData.items || []} | ||
| <ServiceOverviewTransactionsTable |
There was a problem hiding this comment.
Why is it still called ServiceOverviewTransactionsTable if it's not on the service overview?
There was a problem hiding this comment.
Thanks, I actually forgot to move it to the shared folder and rename it.
There was a problem hiding this comment.
Fixed it here: b8209e6
💚 Build SucceededMetrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 3, 2021
…time comparison to the Transactions page (elastic#107299) * adding comparison to transactions pages * adding new transactions table * adding throughput * refactoring transacon group api * adding missing filter * fixing i18n * fixing tests * addressing PR comments * moving table to shared folder Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
Aug 3, 2021
…time comparison to the Transactions page (#107299) (#107576) * adding comparison to transactions pages * adding new transactions table * adding throughput * refactoring transacon group api * adding missing filter * fixing i18n * fixing tests * addressing PR comments * moving table to shared folder Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Cauê Marcondes <55978943+cauemarcondes@users.noreply.github.com>
streamich
pushed a commit
to vadimkibana/kibana
that referenced
this pull request
Aug 8, 2021
…time comparison to the Transactions page (elastic#107299) * adding comparison to transactions pages * adding new transactions table * adding throughput * refactoring transacon group api * adding missing filter * fixing i18n * fixing tests * addressing PR comments * moving table to shared folder Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #91848
closes #106319
I'm closing both issues in one PR. Not ideal, but to be able to add comparison to the transactions pages I'll need to use the same components as the service overview.