[maps] fix More than 2 maps embeddables with geo-shape layers results in empty layers for 3+ #107442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in empty layers for 3+
nreese
added
release_note:fix
[Deprecated-Use Team:Presentation]Team:Geo
|
Pinging @elastic/kibana-gis (Team:Geo) |
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
kindsun
approved these changes
Aug 2, 2021
nreese
added
the
auto-backport
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 3, 2021
… in empty layers for 3+ (elastic#107442) * [maps] fix More than 2 maps embeddables with geo-shape layers results in empty layers for 3+ * comment * add unit test * eslint
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 3, 2021
… in empty layers for 3+ (elastic#107442) * [maps] fix More than 2 maps embeddables with geo-shape layers results in empty layers for 3+ * comment * add unit test * eslint
streamich
pushed a commit
to vadimkibana/kibana
that referenced
this pull request
Aug 8, 2021
… in empty layers for 3+ (elastic#107442) * [maps] fix More than 2 maps embeddables with geo-shape layers results in empty layers for 3+ * comment * add unit test * eslint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #107293
On the surface, it appeared that indexPattern.flattenHit(hit) returned objects with missing properties from the flatten hit cache. Upon further investigation, the reason why the cache was missing properties was that Maps was deleting the geometry property and this deletion occur on the object instance from flatten_hit cache. The fix is to expand the results of flattenHit so that changes made by Maps do not pollute the flatten_hit cache.