Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cases] Fix connector's icon bug #107633

Merged
merged 2 commits into from
Aug 4, 2021
Merged

Conversation

cnasikas
Copy link
Member

@cnasikas cnasikas commented Aug 4, 2021

Summary

The triggersActionsUi provides access to the actionTypeRegistry. Cases use the actionTypeRegistry to get the icon of the connector. If the type of the connector is not registered to the actionTypeRegistry an error will be thrown if you try to get the action type from the registry. The error is not being handled properly by Cases leading to broken Kibana.

Steps to reproduce:

  1. Create a case.
  2. Push it to an external service like Jira.
  3. Change the connector to none.
  4. Go back to the All cases page.

You should see the following error:

Screenshot 2021-08-04 at 2 31 00 PM

Also, the connector icon being shown on the All cases page is wrong. The page shows the icon of the connector that is selected for the particular case and that of the last pushed connector.

Steps to reproduce:

  1. Create a case.
  2. Push it to SN.
  3. Change the connector to Jira.
  4. Go back to the All cases page.

You should see the Jira icon instead of the SN icon. Example:

Screenshot 2021-08-04 at 2 37 00 PM

This PR fixes both bugs.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@cnasikas cnasikas added bug Fixes for quality problems that affect the customer experience v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting Security Solution Threat Hunting Team v7.15.0 v7.14.1 labels Aug 4, 2021
@cnasikas cnasikas self-assigned this Aug 4, 2021
@cnasikas cnasikas requested a review from a team as a code owner August 4, 2021 11:39
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cases 529.0KB 579.6KB +50.6KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
cases 131.7KB 131.7KB -66.0B
Unknown metric groups

async chunk count

id before after diff
cases 15 14 -1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @cnasikas

@cnasikas cnasikas merged commit a89f6a1 into elastic:master Aug 4, 2021
@cnasikas cnasikas deleted the fix_icon_bug branch August 4, 2021 16:21
cnasikas added a commit to cnasikas/kibana that referenced this pull request Aug 4, 2021
cnasikas added a commit to cnasikas/kibana that referenced this pull request Aug 4, 2021
streamich pushed a commit to vadimkibana/kibana that referenced this pull request Aug 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting Security Solution Threat Hunting Team v7.14.1 v7.15.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants