-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Cases] Fix connector's icon bug #107633
Merged
Merged
[Cases] Fix connector's icon bug #107633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnasikas
added
bug
Fixes for quality problems that affect the customer experience
v8.0.0
release_note:skip
Skip the PR/issue when compiling release notes
Team:Threat Hunting
Security Solution Threat Hunting Team
v7.15.0
v7.14.1
labels
Aug 4, 2021
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
jonathan-buttner
approved these changes
Aug 4, 2021
💚 Build SucceededMetrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: cc @cnasikas |
cnasikas
added a commit
to cnasikas/kibana
that referenced
this pull request
Aug 4, 2021
cnasikas
added a commit
to cnasikas/kibana
that referenced
this pull request
Aug 4, 2021
cnasikas
added a commit
that referenced
this pull request
Aug 4, 2021
cnasikas
added a commit
that referenced
this pull request
Aug 4, 2021
streamich
pushed a commit
to vadimkibana/kibana
that referenced
this pull request
Aug 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Fixes for quality problems that affect the customer experience
release_note:skip
Skip the PR/issue when compiling release notes
Team:Threat Hunting
Security Solution Threat Hunting Team
v7.14.1
v7.15.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
triggersActionsUi
provides access to theactionTypeRegistry
. Cases use theactionTypeRegistry
to get the icon of the connector. If the type of the connector is not registered to theactionTypeRegistry
an error will be thrown if you try to get the action type from the registry. The error is not being handled properly by Cases leading to broken Kibana.Steps to reproduce:
You should see the following error:
Also, the connector icon being shown on the All cases page is wrong. The page shows the icon of the connector that is selected for the particular case and that of the last pushed connector.
Steps to reproduce:
You should see the Jira icon instead of the SN icon. Example:
This PR fixes both bugs.
Checklist
Delete any items that are not applicable to this PR.
For maintainers