[FieldFormats] Add editors tests #107770
Merged
[FieldFormats] Add editors tests #107770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dosant
added
Feature:FieldFormatters
release_note:skip
Dosant
commented
Aug 9, 2021
| await esArchiver.emptyKibanaIndex(); | ||
| }); | ||
|
|
||
| describe('set and change field formatter', function describeIndexTests() { |
There was a problem hiding this comment.
this test existed before. Displayed as new because of .js -> .ts conversion
|
Pinging @elastic/kibana-app-services (Team:AppServices) |
mattkime
approved these changes
Aug 9, 2021
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
💔 Backport failed
To backport manually run: |
Dosant
added a commit
to Dosant/kibana
that referenced
this pull request
Aug 10, 2021
# Conflicts: # test/common/services/index.ts
Dosant
added a commit
that referenced
this pull request
Aug 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Close #59567
As per #59567 field formats editors didn't have many tests. This pr adds functional tests for field formats editors focusing on specific field formats editing capabilities and not focusing on string conversions part (this part is covered by functional tests).
This tries to test different combinations of field editors for different field types with different options. Of course it won't cover every possible combination, but the sample is pretty extensive and better then nothing
Each test roughly looks like this: