Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] Fix the API docs bug, where optional functions on interfaces were losing their children. (#107236) #107905

Merged
merged 1 commit into from
Aug 9, 2021

Conversation

stacey-gammon
Copy link
Contributor

Backports the following commits to 7.x:

…ing their children. (elastic#107236)

* Fix the bug and update tests

* update api docs

* Fix tests
# Conflicts:
#	api_docs/charts.mdx
#	api_docs/data.json
#	api_docs/data.mdx
#	api_docs/data_autocomplete.mdx
#	api_docs/data_field_formats.mdx
#	api_docs/data_index_patterns.mdx
#	api_docs/data_query.mdx
#	api_docs/data_search.json
#	api_docs/data_search.mdx
#	api_docs/data_ui.mdx
#	api_docs/deprecations_by_api.mdx
#	api_docs/deprecations_by_plugin.mdx
#	api_docs/es_ui_shared.mdx
#	api_docs/fleet.mdx
#	api_docs/reporting.json
#	api_docs/rule_registry.mdx
#	api_docs/security_solution.json
#	api_docs/security_solution.mdx
#	api_docs/timelines.json
#	api_docs/timelines.mdx
#	api_docs/visualizations.mdx
@stacey-gammon stacey-gammon enabled auto-merge (squash) August 9, 2021 14:30
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

API count

id before after diff
actions 117 119 +2
alerting 242 243 +1
apm 39 42 +3
bfetch 73 77 +4
cases 451 459 +8
charts 194 199 +5
core 2367 2454 +87
data 3690 3735 +45
dataVisualizer 104 108 +4
embeddable 456 460 +4
encryptedSavedObjects 28 29 +1
esUiShared 90 92 +2
expressions 2004 2030 +26
features 215 216 +1
fieldFormats 265 268 +3
fleet 1144 1149 +5
home 94 101 +7
indexPatternFieldEditor 41 44 +3
inspector 101 102 +1
kibanaLegacy 66 70 +4
kibanaReact 262 270 +8
kibanaUtils 551 600 +49
lens 207 208 +1
licensing 117 118 +1
maps 204 213 +9
ml 278 279 +1
observability 219 223 +4
presentationUtil 176 178 +2
ruleRegistry 89 95 +6
savedObjects 213 220 +7
savedObjectsTaggingOss 89 90 +1
securitySolution 1301 1325 +24
share 123 126 +3
spaces 106 110 +4
spacesOss 72 77 +5
taskManager 52 53 +1
telemetryCollectionManager 29 34 +5
timelines 899 928 +29
usageCollection 57 58 +1
visualizations 270 276 +6
total +383

API count missing comments

id before after diff
actions 117 119 +2
alerting 234 235 +1
apm 39 42 +3
bfetch 62 66 +4
cases 409 417 +8
charts 163 168 +5
core 1081 1165 +84
data 3172 3217 +45
dataVisualizer 104 108 +4
embeddable 384 388 +4
encryptedSavedObjects 26 27 +1
esUiShared 88 90 +2
expressions 1569 1595 +26
features 97 98 +1
fieldFormats 235 238 +3
fleet 1048 1049 +1
home 70 77 +7
indexPatternFieldEditor 36 39 +3
inspector 78 79 +1
kibanaLegacy 62 66 +4
kibanaReact 232 240 +8
kibanaUtils 359 406 +47
lens 191 192 +1
licensing 42 43 +1
maps 203 212 +9
ml 274 275 +1
observability 219 223 +4
presentationUtil 149 151 +2
ruleRegistry 89 95 +6
savedObjects 199 206 +7
savedObjectsTaggingOss 50 51 +1
securitySolution 1250 1274 +24
share 83 86 +3
spaces 0 4 +4
spacesOss 5 10 +5
taskManager 25 26 +1
telemetryCollectionManager 29 34 +5
timelines 779 808 +29
usageCollection 16 17 +1
visualizations 252 258 +6
total +374

API count with any type

id before after diff
core 148 149 +1
data 54 59 +5
dataVisualizer 3 5 +2
embeddable 4 5 +1
esUiShared 4 5 +1
expressions 58 65 +7
home 0 3 +3
indexPatternFieldEditor 1 2 +1
kibanaReact 7 8 +1
total +22

Non-exported public API item count

id before after diff
triggersActionsUi 19 18 -1

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stacey-gammon stacey-gammon merged commit 7111bcf into elastic:7.x Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants