Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Discover] Set ownfocus to false when displaying the document flyout #108646

Merged
merged 5 commits into from
Sep 10, 2021
Merged

[Discover] Set ownfocus to false when displaying the document flyout #108646

merged 5 commits into from
Sep 10, 2021

Conversation

kertal
Copy link
Member

@kertal kertal commented Aug 16, 2021 •
edited
Loading

Summary

A while ago the ownFocus property of EuiFlyout was set to a new default (false). This no longer allowed in Discover new table to e.g. select records in the document table, while the EuiFlyout was active. This PR restores this functionality. On top of that, due to recent font changes the time column was no longer without truncation.

Now it looks like this (background accessible, no more time column truncation)
Bildschirmfoto 2021-08-16 um 07 42 32

@kertal kertal self-assigned this Aug 16, 2021
@kertal kertal added Feature:Discover Discover Application Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Aug 16, 2021
@kertal kertal added release_note:skip Skip the PR/issue when compiling release notes v7.15.0 v8.0.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Aug 16, 2021
@kertal kertal changed the title [Discover] Set Document flyout to now own focus [Discover] Set Document flyout to not own focus Aug 16, 2021
@kertal kertal marked this pull request as ready for review August 17, 2021 07:49
@kertal kertal requested a review from a team August 17, 2021 07:49
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@kertal kertal changed the title [Discover] Set Document flyout to not own focus [Discover] Set ownfocus to false when displaying the document flyout Aug 17, 2021
@mistic mistic added v7.16.0 and removed v7.15.0 labels Aug 18, 2021
@timroes timroes added Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. and removed Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Aug 31, 2021
@timroes timroes requested review from a team and removed request for a team August 31, 2021 15:03
@kertal
Copy link
Member Author

kertal commented Sep 9, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
discover 524.2KB 524.2KB +61.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @kertal

@kertal kertal requested a review from majagrubic September 10, 2021 07:51
timroes
timroes approved these changes Sep 10, 2021
View reviewed changes
Copy link
Contributor

@timroes timroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Chrome Linux. Works as expected. Code LGTM

@kertal kertal merged commit 53ba2c4 into elastic:master Sep 10, 2021
@kibanamachine
Copy link
Contributor

💔 Backport failed

Status Branch Result
❌ 7.x Commit could not be cherrypicked due to conflicts

To backport manually run:
node scripts/backport --pr 108646

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Sep 14, 2021
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 108646 or prevent reminders by adding the backport:skip label.

1 similar comment
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 108646 or prevent reminders by adding the backport:skip label.

@kertal kertal mentioned this pull request Sep 16, 2021
Merged
kertal added a commit to kertal/kibana that referenced this pull request Sep 16, 2021
@kertal
[Discover] Set ownfocus to false when displaying the document flyout (e…
328908f 
…lastic#108646)

# Conflicts:
#	test/functional/apps/discover/_data_grid_doc_table.ts
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Sep 16, 2021
kertal added a commit that referenced this pull request Sep 16, 2021
@kertal
[Discover] Set ownfocus to false when displaying the document flyout (#…
597e69c 
…108646) (#112379)

# Conflicts:
#	test/functional/apps/discover/_data_grid_doc_table.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timroes timroes timroes approved these changes

@majagrubic majagrubic Awaiting requested review from majagrubic

Assignees

@kertal kertal

Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Discover Discover Application release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kertal @elasticmachine @kibanamachine @timroes @mistic