Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Replace hard-coded link to rules documentation #109021

Merged
merged 2 commits into from
Aug 30, 2021

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Aug 17, 2021

Summary

Related to #88107
This PR replaces a hard-coded documentation link with the use of a keyword from the https://github.com/elastic/kibana/blob/master/src/core/public/doc_links/doc_links_service.ts, which is tested as part of the documentation build.

@lcawl lcawl changed the title Replace hard-coded link to APM rules [APM] Replace hard-coded link to rules documentation Aug 18, 2021
@lcawl lcawl marked this pull request as ready for review August 26, 2021 00:48
@lcawl lcawl requested review from a team as code owners August 26, 2021 00:48
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Aug 26, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@lcawl
Copy link
Contributor Author

lcawl commented Aug 30, 2021

@elasticmachine merge upstream

@lcawl lcawl added the release_note:skip Skip the PR/issue when compiling release notes label Aug 30, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
apm 46.2KB 46.0KB -232.0B
core 417.4KB 417.5KB +39.0B
total -193.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@lcawl lcawl merged commit f41ab35 into elastic:master Aug 30, 2021
@lcawl lcawl deleted the apm-links branch August 30, 2021 21:41
lcawl added a commit to lcawl/kibana that referenced this pull request Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:alerting release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support v7.16.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants