Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes flakiness in load and save agg-based visualizations #109066

Merged
merged 2 commits into from
Aug 19, 2021
Merged

Fixes flakiness in load and save agg-based visualizations #109066

merged 2 commits into from
Aug 19, 2021

Conversation

stratoula
Copy link
Contributor

@stratoula stratoula commented Aug 18, 2021 •
edited
Loading

Summary

Closes #97538

Something goes off here with the click event on the list. It seems to fail mainly in cloud so I assume that it has to do with a race condition. I have changed the implementation in order to first locate the visualization and then click it. I think that it will solve the flakiness.

image

Flaky test runner https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/1826/

Checklist

@stratoula stratoula changed the title Fix flakiness in load and save agg-based visualizations Fixes flakiness in load and save agg-based visualizations Aug 18, 2021
@stratoula
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stratoula stratoula added Feature:Visualizations Generic visualization features (in case no more specific feature label is available) release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.15.0 v8.0.0 labels Aug 18, 2021
@stratoula stratoula requested a review from liza-mae August 18, 2021 15:54
@stratoula stratoula marked this pull request as ready for review August 18, 2021 15:54
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@mistic mistic added v7.16.0 and removed v7.15.0 labels Aug 18, 2021
liza-mae
liza-mae approved these changes Aug 18, 2021
View reviewed changes
Copy link
Contributor

@liza-mae liza-mae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stratoula stratoula added v7.15.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Aug 19, 2021
@stratoula stratoula merged commit 2172b88 into elastic:master Aug 19, 2021
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Aug 19, 2021
@stratoula @kibanamachine
Fix flakiness in load and save agg-based visualizations (elastic#109066)
a5e752c 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine mentioned this pull request Aug 19, 2021
Merged
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Aug 19, 2021
@stratoula @kibanamachine
Fix flakiness in load and save agg-based visualizations (elastic#109066)
4a937e4 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine mentioned this pull request Aug 19, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.15
✅ 7.x

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Aug 19, 2021
@kibanamachine @stratoula
Fix flakiness in load and save agg-based visualizations (#109066) (#1…
613f0d9 
…09201)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
kibanamachine added a commit that referenced this pull request Aug 19, 2021
@kibanamachine @stratoula
Fix flakiness in load and save agg-based visualizations (#109066) (#1…
2770db2 
…09200)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liza-mae liza-mae liza-mae approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Visualizations Generic visualization features (in case no more specific feature label is available) release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.15.0 v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
5 participants
@stratoula @kibanamachine @elasticmachine @liza-mae @mistic