Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase width of service inventory sparkplot columns #109137

Merged
merged 4 commits into from
Aug 19, 2021
Merged

Increase width of service inventory sparkplot columns #109137

merged 4 commits into from
Aug 19, 2021

Conversation

smith
Copy link
Contributor

@smith smith commented Aug 18, 2021

From 160 to 176px. Prevents overlapping of the labels.

Before After
CleanShot 2021-08-18 at 11 51 59@2x CleanShot 2021-08-18 at 11 51 22@2x

Fixes #109103.

@smith
Increase width of service inventory sparkplot columns
cd080ca 
From 160 to 176px. Prevents overlapping of the labels.

Fixes elastic#109103.
@smith smith added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v7.15.0 labels Aug 18, 2021
@smith smith requested a review from a team as a code owner August 18, 2021 16:53
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Aug 18, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@mistic mistic added v7.16.0 and removed v7.15.0 labels Aug 18, 2021
cauemarcondes
cauemarcondes approved these changes Aug 18, 2021
View reviewed changes
Copy link
Contributor

@cauemarcondes cauemarcondes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smith
Copy link
Contributor Author

smith commented Aug 18, 2021

@elasticmachine merge upstream

@smith
Copy link
Contributor Author

smith commented Aug 18, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@smith smith merged commit 09f122b into elastic:master Aug 19, 2021
@smith smith deleted the nls/spark-width branch August 19, 2021 02:25
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 19, 2021
@smith @kibanamachine
Increase width of service inventory sparkplot columns (elastic#109137)
df82ae7 
From 160 to 176px. Prevents overlapping of the labels.

Fixes elastic#109103.
@kibanamachine kibanamachine mentioned this pull request Aug 19, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Aug 19, 2021
@kibanamachine @smith
Increase width of service inventory sparkplot columns (#109137) (#109193
d9c71d4 
)

From 160 to 176px. Prevents overlapping of the labels.

Fixes #109103.

Co-authored-by: Nathan L Smith <nathan.smith@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cauemarcondes cauemarcondes cauemarcondes approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[APM] Sparkline labels are overlaying on top of each other
5 participants
@smith @elasticmachine @kibanamachine @cauemarcondes @mistic