Add multi-space support to SO management and import/export API #109196

pgayvallet · 2021-08-19T05:44:54Z

Summary

Fix #91615

Remaining work:

add unit tests for export logic changes
add unit tests for import logic changes
add the _cross_import endpoint to core
resolve_import_errors FTR test suite
adapt checkOriginConflict to support importNamespaces mode
validate the presence of namespaces when importNamespaces=true in importSavedObjectsFromStream

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
This was checked for cross-browser compatibility

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk	Probability	Severity	Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space.	Low	High	Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks.	High	Low	Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled.	Medium	High	Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

This was checked for breaking API changes and was labeled appropriately

…s-export

…jects are selected

…s-export

…st suite

…s-export

kibanamachine · 2021-09-01T19:15:54Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 4423559
Storybooks Preview
Pipeline Steps (look for red circles / failed steps)
Interpreting CI Failures

Failed CI Steps

Test Failures

Kibana Pipeline / jest / Jest Tests.src/plugins/saved_objects_management/public/management_section/objects_table.SavedObjectsTable export should allow the user to choose when exporting all

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

Stack Trace

Error: expect(received).toMatchSnapshot()

Snapshot name: `SavedObjectsTable export should allow the user to choose when exporting all 1`

- Snapshot  - 1
+ Received  + 2

@@ -1,8 +1,8 @@
  <ExportModal
    filteredItemCount={4}
-   includeNamespaces={true}
+   includeNamespaces={false}
    includeReferences={true}
    onCancel={[Function]}
    onExport={[Function]}
    onIncludeNamespacesChange={[Function]}
    onIncludeReferenceChange={[Function]}
@@ -33,6 +33,7 @@
        "index-pattern": true,
        "search": true,
        "visualization": true,
      }
    }
+   showIncludeNamespacesToggle={false}
  />
    at Object.<anonymous> (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/src/plugins/saved_objects_management/public/management_section/objects_table/saved_objects_table.test.tsx:399:45)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
    at _callCircusTest (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:212:5)
    at _runTest (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:149:3)
    at _runTestsForDescribeBlock (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:63:9)
    at _runTestsForDescribeBlock (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:57:9)
    at _runTestsForDescribeBlock (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:57:9)
    at run (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:25:3)
    at runAndTransformResultsToJestFormat (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:176:21)
    at jestAdapter (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:109:19)
    at runTestInternal (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runner/build/runTest.js:380:16)
    at runTest (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runner/build/runTest.js:472:34)
    at Object.worker (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runner/build/testWorker.js:133:12)

Kibana Pipeline / jest / Jest Tests.src/plugins/saved_objects_management/public/management_section/objects_table.SavedObjectsTable export should export all

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

Stack Trace

Error: expect(jest.fn()).toHaveBeenCalledWith(...expected)

- Expected
+ Received

@@ -25,12 +25,14 @@
      "options": [Function mockConstructor],
      "patch": [Function mockConstructor],
      "post": [Function mockConstructor],
      "put": [Function mockConstructor],
    },
-   "includeNamespaces": true,
+   "includeNamespaces": false,
    "includeReferencesDeep": true,
+   "references": undefined,
+   "search": undefined,
    "types": Array [
      "index-pattern",
      "visualization",
      "dashboard",
      "search",,

Number of calls: 1
    at Object.<anonymous> (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/src/plugins/saved_objects_management/public/management_section/objects_table/saved_objects_table.test.tsx:416:46)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
    at _callCircusTest (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:212:5)
    at _runTest (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:149:3)
    at _runTestsForDescribeBlock (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:63:9)
    at _runTestsForDescribeBlock (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:57:9)
    at _runTestsForDescribeBlock (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:57:9)
    at run (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:25:3)
    at runAndTransformResultsToJestFormat (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:176:21)
    at jestAdapter (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:109:19)
    at runTestInternal (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runner/build/runTest.js:380:16)
    at runTest (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runner/build/runTest.js:472:34)
    at Object.worker (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runner/build/testWorker.js:133:12)

Kibana Pipeline / jest / Jest Tests.src/plugins/saved_objects_management/public/management_section/objects_table.SavedObjectsTable export should export all, accounting for the current search criteria

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

Stack Trace

Error: expect(jest.fn()).toHaveBeenCalledWith(...expected)

Expected: {"http": {"addLoadingCountSource": [Function mockConstructor], "anonymousPaths": {"isAnonymous": [Function mockConstructor], "register": [Function mockConstructor]}, "basePath": {"basePath": "", "get": [Function anonymous], "prepend": [Function anonymous], "publicBaseUrl": undefined, "remove": [Function anonymous], "serverBasePath": ""}, "delete": [Function mockConstructor], "externalUrl": {"validateUrl": [Function mockConstructor]}, "fetch": [Function mockConstructor], "get": [Function mockConstructor], "getLoadingCount$": [Function mockConstructor], "head": [Function mockConstructor], "intercept": [Function mockConstructor], "options": [Function mockConstructor], "patch": [Function mockConstructor], "post": [Function mockConstructor], "put": [Function mockConstructor]}, "includeNamespaces": true, "includeReferencesDeep": true, "search": "test*", "types": ["index-pattern", "visualization", "dashboard", "search"]}
Received
       1
        @@ -25,13 +25,14 @@
              "options": [Function mockConstructor],
              "patch": [Function mockConstructor],
              "post": [Function mockConstructor],
              "put": [Function mockConstructor],
            },
        -   "includeNamespaces": true,
        +   "includeNamespaces": false,
            "includeReferencesDeep": true,
        -   "search": "test*",
        +   "references": undefined,
        +   "search": undefined,
            "types": Array [
              "index-pattern",
              "visualization",
              "dashboard",
              "search",,
       2
        @@ -25,12 +25,13 @@
              "options": [Function mockConstructor],
              "patch": [Function mockConstructor],
              "post": [Function mockConstructor],
              "put": [Function mockConstructor],
            },
        -   "includeNamespaces": true,
        +   "includeNamespaces": false,
            "includeReferencesDeep": true,
        +   "references": undefined,
            "search": "test*",
            "types": Array [
              "index-pattern",
              "visualization",
              "dashboard",,

Number of calls: 2
    at Object.<anonymous> (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/src/plugins/saved_objects_management/public/management_section/objects_table/saved_objects_table.test.tsx:446:46)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
    at _callCircusTest (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:212:5)
    at _runTest (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:149:3)
    at _runTestsForDescribeBlock (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:63:9)
    at _runTestsForDescribeBlock (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:57:9)
    at _runTestsForDescribeBlock (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:57:9)
    at run (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:25:3)
    at runAndTransformResultsToJestFormat (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:176:21)
    at jestAdapter (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:109:19)
    at runTestInternal (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runner/build/runTest.js:380:16)
    at runTest (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runner/build/runTest.js:472:34)
    at Object.worker (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runner/build/testWorker.js:133:12)

and 8 more failures, only showing the first 3.

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`savedObjectsManagement`	83	90	+7

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`savedObjectsManagement`	140.0KB	146.6KB	+6.6KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`savedObjectsManagement`	38.3KB	42.1KB	+3.8KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

pgayvallet · 2021-09-03T06:27:47Z

PR on hold, see #91615 (comment)

pgayvallet added 2 commits August 17, 2021 20:21

some WIP

ed9361f

still some WIP

c619f28

pgayvallet mentioned this pull request Aug 20, 2021

Remove spacesOss plugin #109258

Merged

6 tasks

pgayvallet added 7 commits August 24, 2021 07:53

Merge remote-tracking branch 'upstream/master' into kbn-91615-multi-n…

e102d9b

…s-export

fix conflicts, add context provider, add spaces column to main table

a96fb19

add spaces column to delete modal

d6c88d8

include namespaces for per-type export

d826636

add export option to export all modal

260502e

add export option to export by id menu

333e1b4

update reference collection stage of the export process

6f17593

pgayvallet mentioned this pull request Aug 25, 2021

Add multi-namespace capabilities to SOR.bulkGet #109197

Closed

pgayvallet added 13 commits August 25, 2021 10:44

remove added API from mock

c952f96

Merge remote-tracking branch 'upstream/master' into kbn-91615-multi-n…

9b1cafb

…s-export

fix column service tests

050f684

update table snapshots

1d22bea

fix so table unit tests

ca2c639

fix exporter tests

ea98619

fix collect tests

8ebf1a9

add base tests for multi-ns collection

162dc23

Merge remote-tracking branch 'upstream/master' into kbn-91615-multi-n…

ee73feb

…s-export

fix test types

87feb8d

update generated doc

d5200b1

modifying import script, first iteration

9208b7d

fix / adapt most of the import unit test suites

f04224c

pgayvallet added Feature:Saved Objects Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.16.0 release_note:skip Skip the PR/issue when compiling release notes labels Aug 27, 2021

pgayvallet added 2 commits August 27, 2021 14:34

fix remaining test suites

cf8de9f

Merge remote-tracking branch 'upstream/master' into kbn-91615-multi-n…

cb55d71

…s-export

pgayvallet added 21 commits August 31, 2021 10:47

hide actions for outside objects and forbid to delete when outside ob…

8a889f6

…jects are selected

Merge remote-tracking branch 'upstream/master' into kbn-91615-multi-n…

bb3669b

…s-export

fix copy to space unit tests

646a0d4

fix types

8cb149f

initial export across space test suite

1a9eda0

create export_across_space endpoint and finish security_and_spaces te…

3bb85eb

…st suite

adapt endpoints

702f7ff

prepare the import_across_space route

c7726ae

Merge remote-tracking branch 'upstream/master' into kbn-91615-multi-n…

d479c78

…s-export

add import_across_space test suite

f3bbf18

start to adapt client-side for import_across_space

1adcf51

add resolve_import_errors_across_space endpoint

2895d7e

lint

ec2e056

use getObjKey from import, remove from service

7f8cdcd

add tests for getObjectKey

83fb8cd

fix test types

f8ac6e1

fixing API integration tests

6d876b3

small cleanups

88027ee

add collect test

1e8f092

add exporter test

461c7b7

minor fixes

4423559

This was referenced Sep 1, 2021

Saved objects import/export should include spaces #91615

Open

[SOR] normalize initialNamespaces for create and bulkCreate #110936

Merged

[SOR] use initialNamespaces when checking for conflict for create and bulkCreate #111023

Merged

lukeelmers added stalled and removed v7.16.0 labels Nov 16, 2021

pgayvallet mentioned this pull request May 2, 2022

Allow the SavedObjectsClient to work outside of a space #131254

Open

legrego closed this Jul 17, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add multi-space support to SO management and import/export API #109196

Add multi-space support to SO management and import/export API #109196

pgayvallet commented Aug 19, 2021 •

edited

Loading

kibanamachine commented Sep 1, 2021 •

edited

Loading

Standard Out

Stack Trace

Standard Out

Stack Trace

Standard Out

Stack Trace

pgayvallet commented Sep 3, 2021

Add multi-space support to SO management and import/export API #109196

Add multi-space support to SO management and import/export API #109196

Conversation

pgayvallet commented Aug 19, 2021 • edited Loading

Summary

Checklist

Risk Matrix

For maintainers

kibanamachine commented Sep 1, 2021 • edited Loading

💔 Build Failed

Failed CI Steps

Test Failures

Standard Out

Stack Trace

Standard Out

Stack Trace

Standard Out

Stack Trace

Metrics [docs]

Module Count

Async chunks

Page load bundle

History

pgayvallet commented Sep 3, 2021

pgayvallet commented Aug 19, 2021 •

edited

Loading

kibanamachine commented Sep 1, 2021 •

edited

Loading