[Flaky-tests] Fix SOM edit-saved-objects test #109215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afharo
added
the
release_note:skip
pgayvallet
approved these changes
Aug 19, 2021
afharo
added
the
auto-backport
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 19, 2021
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 19, 2021
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 19, 2021
kibanamachine
added a commit
that referenced
this pull request
Aug 19, 2021
kibanamachine
added a commit
that referenced
this pull request
Aug 19, 2021
kibanamachine
added a commit
that referenced
this pull request
Aug 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #105313
This PR adds a small wait after clicking the Save Edit button to allow the re-render to occur. There were some moments when the checks after the click event happened before the render occurred so, for example, the table was not in "loading" state yet, and the logic assumed it had already refreshed because of that.
In my tests, the small delay is enough: flaky-test-runner succeded after 42 executions.
Checklist
Delete any items that are not applicable to this PR.
For maintainers