Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Discover] Fix discover footer width #109403

Merged
merged 3 commits into from
Aug 23, 2021
Merged

[Discover] Fix discover footer width #109403

merged 3 commits into from
Aug 23, 2021
+36 −22

Conversation

dimaanj
Copy link
Contributor

@dimaanj dimaanj commented Aug 20, 2021

Summary

Fixes #84805

This PR adjusts table footer to the full width.

4FE2C480-EAA4-4311-A30A-80A03BD1C861

Checklist

@dimaanj dimaanj added Feature:Discover Discover Application Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v7.15.0 v7.16.0 labels Aug 20, 2021
@dimaanj dimaanj requested review from kertal and majagrubic August 20, 2021 10:13
@dimaanj dimaanj self-assigned this Aug 20, 2021
@dimaanj dimaanj requested a review from a team August 20, 2021 10:13
@dimaanj dimaanj requested a review from a team as a code owner August 20, 2021 10:13
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

andreadelrio
andreadelrio approved these changes Aug 20, 2021
View reviewed changes
Copy link
Contributor

@andreadelrio andreadelrio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested locally.

@dimaanj
Copy link
Contributor Author

dimaanj commented Aug 23, 2021

@elasticmachine merge upstream

kertal
kertal approved these changes Aug 23, 2021
View reviewed changes
Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; tested via deployment in Chrome, Firefox, Safari, works as expected 👍

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
discover 556.1KB 556.5KB +342.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @dmitriynj

@dimaanj dimaanj merged commit 68afb8d into elastic:master Aug 23, 2021
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Aug 23, 2021
@dimaanj @kibanamachine
[Discover] Fix discover footer width (elastic#109403)
aeace7d 
* [Discover] fix discover footer width

* [Discover] fix types

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine mentioned this pull request Aug 23, 2021
Merged
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Aug 23, 2021
@dimaanj @kibanamachine
[Discover] Fix discover footer width (elastic#109403)
981ce5c 
* [Discover] fix discover footer width

* [Discover] fix types

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine mentioned this pull request Aug 23, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.15
✅ 7.x

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Aug 23, 2021
@kibanamachine @dimaanj
[Discover] Fix discover footer width (#109403) (#109620)
1bb95ac 
* [Discover] fix discover footer width

* [Discover] fix types

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Dmitry Tomashevich <39378793+Dmitriynj@users.noreply.github.com>
kibanamachine added a commit that referenced this pull request Aug 23, 2021
@kibanamachine @dimaanj
[Discover] Fix discover footer width (#109403) (#109621)
eefe8b5 
* [Discover] fix discover footer width

* [Discover] fix types

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Dmitry Tomashevich <39378793+Dmitriynj@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreadelrio andreadelrio andreadelrio approved these changes

@kertal kertal kertal approved these changes

@majagrubic majagrubic Awaiting requested review from majagrubic

Assignees

@dimaanj dimaanj

Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Discover Discover Application release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.15.0 v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Discover] Doc table footer not going full width
5 participants
@dimaanj @elasticmachine @kibanamachine @kertal @andreadelrio