[Upgrade Assistant] Refactor CITs #109536
Conversation
alisonelizabeth
added
Team:Kibana Management
| @@ -46,27 +47,7 @@ describe('Overview - Fix deprecated settings step', () => { | |||
| expect(find('esStatsPanel.criticalDeprecations').text()).toContain('1'); | |||
| }); | |||
|
|
|||
| test('Handles network failure', async () => { | |||
There was a problem hiding this comment.
This test was duplicated in this file.
| @@ -78,7 +59,7 @@ describe('Overview - Fix deprecated settings step', () => { | |||
| expect(exists('noDeprecationsLabel')).toBe(true); | |||
| }); | |||
|
|
|||
| test('Stats panel navigates to deprecations list if clicked', () => { | |||
| test('Stats panel contains link to ES deprecations page', () => { | |||
There was a problem hiding this comment.
Reworded this a bit since the test doesn't actually click the link
|
@sabarasaba do you recall why you introduced the I didn't notice it while reviewing your PR, but when I was looking at the tests again, I found it a bit unclear on what is provided by the Kibana context services object vs. the app context. It seems like we might only need one or the other, but it's possible I might be missing something 😅 . |
|
Pinging @elastic/kibana-stack-management (Team:Stack Management) |
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
I saw in other apps they were using KibanaContext for plugin dependencies and AppContext for the rest of the things (cant exactly recall which ones right now) so I thought it was a pattern or something that everyone follows. But from your comment I understand that is not a thing, so I can work on getting rid of it and just passing everything through AppContext. I've created this issue to keep track of this and will address it soon. |
Addresses the second part of #107053 (comment).
I've co-located the helper files with the tests. For example,
es_deprecations.helpers.tsnow lives in__jest__/client_integration/es_deprecations, rather than the top-levelhelpersdirectory.I think we could consider breaking
es_deprecations.helpers.tsinto smaller files to map to the different test files within this directory, but I'm not sure it's necessary at this time. For now, I tried to scope the actions so it's a little more clear when scanning the file.I also removed the
TestSubjectstypes, as I don't find it very useful and is burdensome to maintain.