-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ensure all kibana.json files have owners and they are consistent #109731
Conversation
@stacey-gammon Wasn't there supposed to be something that validated these files are correct? |
Not merged yet - #108231 however... that PR only requires |
@@ -2,7 +2,7 @@ | |||
"id": "apm", | |||
"owner": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Off topic: I love that we have these plugin manifests. Would it make sense to have a test
section, thereby making it much easier to get an overview and run all tests for a specific plugin:
{
"id": "apm",
"test": {
"unit": "yarn jest",
"cypress": "node x-pack/plugin/apm/scripts/ftr_e2e/cypress_run.js",
"ftr:api:trial": "x-pack/test/apm_api_integration/trial/config.ts",
"ftr:api:basic": "x-pack/test/apm_api_integration/basic/config.ts",
"ftr:functional": "x-pack/test/functional/config.js",
}
}
To run all APM's tests we could have a command like: yarn test apm
. To run a single of APM's tests: yarn test apm ftr:api:basic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's an interesting idea for sure. We're getting closer to moving the tests out of the root x-pack/test dir and into the plugins, which might make this a little less helpful but it's an interesting project to think through.
Pinging @elastic/apm-ui (Team:apm) |
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
…stic#109731) Co-authored-by: spalger <spalger@users.noreply.github.com>
…stic#109731) Co-authored-by: spalger <spalger@users.noreply.github.com>
kibana.json
files now haveowner
fields, but they're not using consistent casing for thegithubTeam
field currently and it was missing from thedashboard_enhanced
plugin.