Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure all kibana.json files have owners and they are consistent #109731

Merged
merged 2 commits into from
Aug 24, 2021

Conversation

spalger
Copy link
Contributor

@spalger spalger commented Aug 23, 2021

kibana.json files now have owner fields, but they're not using consistent casing for the githubTeam field currently and it was missing from the dashboard_enhanced plugin.

@spalger
Copy link
Contributor Author

spalger commented Aug 23, 2021

@stacey-gammon Wasn't there supposed to be something that validated these files are correct?

@stacey-gammon
Copy link
Contributor

Not merged yet - #108231 however... that PR only requires owner not githubTeam so this wouldn't have been caught.

@spalger spalger added release_note:skip Skip the PR/issue when compiling release notes v7.15.0 v7.16.0 v8.0.0 labels Aug 23, 2021
@spalger spalger marked this pull request as ready for review August 23, 2021 21:59
@spalger spalger requested review from a team as code owners August 23, 2021 21:59
@@ -2,7 +2,7 @@
"id": "apm",
"owner": {
Copy link
Member

@sorenlouv sorenlouv Aug 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Off topic: I love that we have these plugin manifests. Would it make sense to have a test section, thereby making it much easier to get an overview and run all tests for a specific plugin:

{
  "id": "apm",
  "test": {
    "unit": "yarn jest",
    "cypress": "node x-pack/plugin/apm/scripts/ftr_e2e/cypress_run.js",
    "ftr:api:trial": "x-pack/test/apm_api_integration/trial/config.ts",
    "ftr:api:basic": "x-pack/test/apm_api_integration/basic/config.ts",
    "ftr:functional": "x-pack/test/functional/config.js",
  }
}

To run all APM's tests we could have a command like: yarn test apm. To run a single of APM's tests: yarn test apm ftr:api:basic

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's an interesting idea for sure. We're getting closer to moving the tests out of the root x-pack/test dir and into the plugins, which might make this a little less helpful but it's an interesting project to think through.

@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Aug 23, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@spalger spalger enabled auto-merge (squash) August 24, 2021 19:09
@spalger spalger added the auto-backport Deprecated - use backport:version if exact versions are needed label Aug 24, 2021
@spalger spalger removed the request for review from a team August 24, 2021 19:09
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@spalger spalger merged commit 213abc4 into elastic:master Aug 24, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 24, 2021
…stic#109731)

Co-authored-by: spalger <spalger@users.noreply.github.com>
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 24, 2021
…stic#109731)

Co-authored-by: spalger <spalger@users.noreply.github.com>
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.15
7.x

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Aug 24, 2021
…9731) (#109968)

Co-authored-by: spalger <spalger@users.noreply.github.com>

Co-authored-by: Spencer <email@spalger.com>
Co-authored-by: spalger <spalger@users.noreply.github.com>
kibanamachine added a commit that referenced this pull request Aug 24, 2021
…9731) (#109969)

Co-authored-by: spalger <spalger@users.noreply.github.com>

Co-authored-by: Spencer <email@spalger.com>
Co-authored-by: spalger <spalger@users.noreply.github.com>
@spalger spalger deleted the fix/kibana-json-owners branch February 2, 2022 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support v7.15.0 v7.16.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants