Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.15] [ML] APM Latency Correlations: Fix empty state (#109813) #110399

Merged
merged 1 commit into from
Aug 27, 2021

Conversation

walterra
Copy link
Contributor

Backports the following commits to 7.15:

- Correctly renders the empty chart state when no data is available.
- Hides the "Click drag to select" and trace samples message when the chart shows an empty state to avoid redundant info.
- Adds jest unit tests that would fail with the previously visible loading indicators.
- Fix a bug with cancelling search strategies.
# Conflicts:
#	x-pack/plugins/apm/public/components/app/correlations/latency_correlations.tsx
#	x-pack/plugins/apm/public/components/app/transaction_details/distribution/index.tsx
@walterra walterra enabled auto-merge (squash) August 27, 2021 11:17
@walterra walterra self-assigned this Aug 27, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 4.4MB 4.4MB +2.1KB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @walterra

@walterra walterra merged commit 880ebcd into elastic:7.15 Aug 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants