Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Add job audit messages API integration tests #110793

Merged
merged 8 commits into from
Sep 2, 2021
Merged

[ML] Add job audit messages API integration tests #110793

merged 8 commits into from
Sep 2, 2021

Conversation

darnautov
Copy link
Contributor

Summary

Part of #106113

Adds API Internation tests for the job audit messages.

Checklist

@darnautov darnautov added :ml v8.0.0 test-api-integration auto-backport Deprecated - use backport:version if exact versions are needed v7.15.0 v7.16.0 labels Sep 1, 2021
@darnautov darnautov self-assigned this Sep 1, 2021
@darnautov darnautov requested a review from a team as a code owner September 1, 2021 12:38
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@darnautov darnautov added the release_note:skip Skip the PR/issue when compiling release notes label Sep 1, 2021
@darnautov darnautov mentioned this pull request Sep 1, 2021
Closed
14 tasks
@pheyos
Copy link
Member

pheyos commented Sep 1, 2021

Checking test stability in a flaky test runner job ...

pheyos
pheyos reviewed Sep 1, 2021
View reviewed changes
Copy link
Member

@pheyos pheyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see these tests coming! 🎉
Left a few comments.

x-pack/test/api_integration/apis/ml/job_audit_messages/clear_messages.ts Show resolved Hide resolved
x-pack/test/api_integration/apis/ml/job_audit_messages/clear_messages.ts Show resolved Hide resolved
x-pack/test/api_integration/apis/ml/job_audit_messages/get_job_audit_messages.ts Outdated Show resolved Hide resolved
@peteharverson peteharverson mentioned this pull request Sep 2, 2021
Closed
90 tasks
jgowdyelastic
jgowdyelastic approved these changes Sep 2, 2021
View reviewed changes
Copy link
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

peteharverson
peteharverson approved these changes Sep 2, 2021
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@darnautov darnautov requested a review from pheyos September 2, 2021 09:31
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @darnautov

pheyos
pheyos approved these changes Sep 2, 2021
View reviewed changes
Copy link
Member

@pheyos pheyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@darnautov darnautov merged commit 0ae7455 into elastic:master Sep 2, 2021
@darnautov darnautov deleted the ml-106113-job_audit_messages-tests branch September 2, 2021 12:43
@kibanamachine kibanamachine mentioned this pull request Sep 2, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 2, 2021
@darnautov @kibanamachine
[ML] Add job audit messages API integration tests (elastic#110793)
9fb6611
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 2, 2021
@darnautov @kibanamachine
[ML] Add job audit messages API integration tests (elastic#110793)
e9657ac
@kibanamachine kibanamachine mentioned this pull request Sep 2, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.15
✅ 7.x

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Sep 2, 2021
@kibanamachine @darnautov
[ML] Add job audit messages API integration tests (#110793) (#110975)
166fa31 
Co-authored-by: Dima Arnautov <dmitrii.arnautov@elastic.co>
kibanamachine added a commit that referenced this pull request Sep 3, 2021
@kibanamachine @darnautov
[ML] Add job audit messages API integration tests (#110793) (#110976)
3815e42 
Co-authored-by: Dima Arnautov <dmitrii.arnautov@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgowdyelastic jgowdyelastic jgowdyelastic approved these changes

@peteharverson peteharverson peteharverson approved these changes

@pheyos pheyos pheyos approved these changes

@alvarezmelissa87 alvarezmelissa87 Awaiting requested review from alvarezmelissa87

Assignees

@darnautov darnautov

Labels
auto-backport Deprecated - use backport:version if exact versions are needed :ml release_note:skip Skip the PR/issue when compiling release notes test-api-integration v7.15.0 v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@darnautov @elasticmachine @pheyos @kibanamachine @peteharverson @jgowdyelastic