Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do not export all the types from licensing plugin #110942

Merged
merged 3 commits into from
Sep 2, 2021
Merged

do not export all the types from licensing plugin #110942

merged 3 commits into from
Sep 2, 2021

Conversation

mshustov
Copy link
Contributor

@mshustov mshustov commented Sep 2, 2021

Summary

Closes #110902

@mshustov mshustov added chore Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.16.0 labels Sep 2, 2021
@mshustov mshustov requested a review from a team as a code owner September 2, 2021 08:17
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

mshustov
mshustov commented Sep 2, 2021
View reviewed changes
x-pack/plugins/licensing/tsconfig.json
@@ -4,7 +4,8 @@
"outDir": "./target/types",
"emitDeclarationOnly": true,
"declaration": true,
"declarationMap": true
"declarationMap": true,
"isolatedModules": true,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to enforce export type expressions when necessary. It prevents leaking an interface implementation.

@mshustov mshustov added the auto-backport Deprecated - use backport:version if exact versions are needed label Sep 2, 2021
@mshustov mshustov enabled auto-merge (squash) September 2, 2021 08:32
afharo
afharo approved these changes Sep 2, 2021
View reviewed changes
x-pack/plugins/licensing/tsconfig.json
@@ -4,7 +4,8 @@
"outDir": "./target/types",
"emitDeclarationOnly": true,
"declaration": true,
"declarationMap": true
"declarationMap": true,
"isolatedModules": true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧡

x-pack/plugins/licensing/public/index.ts Show resolved Hide resolved
@kibanamachine
Copy link
Contributor

kibanamachine commented Sep 2, 2021 •
edited
Loading

⏳ Build in-progress, with failures

Failed CI Steps

Test Failures

Jest Tests.x-pack/plugins/security/server/authorization/privileges.subFeatures when license allows subfeatures, but not a specific sub feature should create minimal privileges, but not augment the primary feature privileges or create the disallowed sub-feature privileges

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

Stack Trace

TypeError: Cannot read property 'platinum' of undefined
    at /var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/x-pack/plugins/security/common/licensing/index.mock.ts:29:11
    at /var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-mock/build/index.js:444:39
    at /var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-mock/build/index.js:452:13
    at licenseHasAtLeast (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-mock/build/index.js:166:19)
    at filter (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/x-pack/plugins/features/server/feature_privilege_iterator/sub_feature_privilege_iterator.ts:29:53)
    at Array.filter (<anonymous>)
    at subFeaturePrivilege (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/x-pack/plugins/features/server/feature_privilege_iterator/sub_feature_privilege_iterator.ts:28:31)
    at subFeaturePrivilegeIterator.next (<anonymous>)
    at mergeWithSubFeatures (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/x-pack/plugins/features/server/feature_privilege_iterator/feature_privilege_iterator.ts:78:14)
    at Object.featurePrivilegeIterator (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/x-pack/plugins/features/server/feature_privilege_iterator/feature_privilege_iterator.ts:63:20)
    at featurePrivilegeIterator.next (<anonymous>)
    at forEach (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/x-pack/plugins/security/server/authorization/privileges/privileges.ts:43:20)
    at Array.forEach (<anonymous>)
    at Object.get (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/x-pack/plugins/security/server/authorization/privileges/privileges.ts:42:29)
    at Object.<anonymous> (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/x-pack/plugins/security/server/authorization/privileges/privileges.test.ts:1904:33)
    at Promise.then.completed (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/utils.js:276:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/utils.js:216:10)
    at _callCircusTest (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:212:40)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
    at _runTest (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:149:3)
    at _runTestsForDescribeBlock (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:63:9)
    at _runTestsForDescribeBlock (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:57:9)
    at _runTestsForDescribeBlock (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:57:9)
    at run (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:25:3)
    at runAndTransformResultsToJestFormat (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:176:21)
    at jestAdapter (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:109:19)
    at runTestInternal (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runner/build/runTest.js:380:16)
    at runTest (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runner/build/runTest.js:472:34)
    at Object.worker (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runner/build/testWorker.js:133:12)
Jest Tests.x-pack/plugins/security/server/authorization/privileges.subFeatures when license allows subfeatures, but and a licensed sub feature should create minimal privileges, augment the primary feature privileges, and create the licensed sub-feature privileges

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

Stack Trace

TypeError: Cannot read property 'platinum' of undefined
    at /var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/x-pack/plugins/security/common/licensing/index.mock.ts:29:11
    at /var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-mock/build/index.js:444:39
    at /var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-mock/build/index.js:452:13
    at licenseHasAtLeast (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-mock/build/index.js:166:19)
    at filter (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/x-pack/plugins/features/server/feature_privilege_iterator/sub_feature_privilege_iterator.ts:29:53)
    at Array.filter (<anonymous>)
    at subFeaturePrivilege (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/x-pack/plugins/features/server/feature_privilege_iterator/sub_feature_privilege_iterator.ts:28:31)
    at subFeaturePrivilegeIterator.next (<anonymous>)
    at mergeWithSubFeatures (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/x-pack/plugins/features/server/feature_privilege_iterator/feature_privilege_iterator.ts:78:14)
    at Object.featurePrivilegeIterator (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/x-pack/plugins/features/server/feature_privilege_iterator/feature_privilege_iterator.ts:63:20)
    at featurePrivilegeIterator.next (<anonymous>)
    at forEach (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/x-pack/plugins/security/server/authorization/privileges/privileges.ts:43:20)
    at Array.forEach (<anonymous>)
    at Object.get (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/x-pack/plugins/security/server/authorization/privileges/privileges.ts:42:29)
    at Object.<anonymous> (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/x-pack/plugins/security/server/authorization/privileges/privileges.test.ts:2135:33)
    at Promise.then.completed (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/utils.js:276:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/utils.js:216:10)
    at _callCircusTest (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:212:40)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
    at _runTest (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:149:3)
    at _runTestsForDescribeBlock (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:63:9)
    at _runTestsForDescribeBlock (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:57:9)
    at _runTestsForDescribeBlock (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:57:9)
    at run (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:25:3)
    at runAndTransformResultsToJestFormat (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:176:21)
    at jestAdapter (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:109:19)
    at runTestInternal (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runner/build/runTest.js:380:16)
    at runTest (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runner/build/runTest.js:472:34)
    at Object.worker (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runner/build/testWorker.js:133:12)
Jest Tests.x-pack/plugins/features/server/feature_privilege_iterator.featurePrivilegeIterator excludes sub-feature privileges when the minimum license is not met with a gold license

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

Stack Trace

TypeError: Cannot read property 'gold' of undefined
    at licenseHasAtLeast (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/x-pack/plugins/features/server/feature_privilege_iterator/feature_privilege_iterator.test.ts:21:12)
    at filter (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/x-pack/plugins/features/server/feature_privilege_iterator/sub_feature_privilege_iterator.ts:29:53)
    at Array.filter (<anonymous>)
    at subFeaturePrivilege (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/x-pack/plugins/features/server/feature_privilege_iterator/sub_feature_privilege_iterator.ts:28:31)
    at subFeaturePrivilegeIterator.next (<anonymous>)
    at mergeWithSubFeatures (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/x-pack/plugins/features/server/feature_privilege_iterator/feature_privilege_iterator.ts:78:14)
    at from (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/x-pack/plugins/features/server/feature_privilege_iterator/feature_privilege_iterator.ts:63:20)
    at featurePrivilegeIterator.next (<anonymous>)
    at Function.from (<anonymous>)
    at Object.<anonymous> (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/x-pack/plugins/features/server/feature_privilege_iterator/feature_privilege_iterator.test.ts:1151:38)
    at Promise.then.completed (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/utils.js:276:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/utils.js:216:10)
    at _callCircusTest (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:212:40)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
    at _runTest (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:149:3)
    at _runTestsForDescribeBlock (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:63:9)
    at _runTestsForDescribeBlock (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:57:9)
    at _runTestsForDescribeBlock (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:57:9)
    at run (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:25:3)
    at runAndTransformResultsToJestFormat (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:176:21)
    at jestAdapter (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:109:19)
    at runTestInternal (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runner/build/runTest.js:380:16)
    at runTest (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runner/build/runTest.js:472:34)
    at Object.worker (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runner/build/testWorker.js:133:12)

and 6 more failures, only showing the first 3.

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mshustov mshustov merged commit 1205ba4 into elastic:master Sep 2, 2021
@kibanamachine kibanamachine mentioned this pull request Sep 2, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 2, 2021
@mshustov @kibanamachine
do not export all the types from licensing plugin (elastic#110942)
0d2158b 
* do not export all the types from licensing plugin

* another export issue
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

@mshustov mshustov deleted the issue-110902-no-export-all branch September 2, 2021 11:46
kibanamachine added a commit that referenced this pull request Sep 2, 2021
@kibanamachine @mshustov
do not export all the types from licensing plugin (#110942) (#110963)
54cea57 
* do not export all the types from licensing plugin

* another export issue

Co-authored-by: Mikhail Shustov <restrry@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afharo afharo afharo approved these changes

@pgayvallet pgayvallet pgayvallet approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed chore release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[core] Remove export* syntax from plugin index files
5 participants
@mshustov @elasticmachine @kibanamachine @pgayvallet @afharo