Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace hard-coded links in infra alerting #111072

Merged
merged 3 commits into from
Sep 9, 2021
Merged

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Sep 3, 2021

Summary

Relates to #88107

This PR replaces occurrences of hard-coded links with the use of the documentation link service, so that they're easier to maintain and are checked during the doc build.

@lcawl lcawl added enhancement New value added to drive a business result release_note:skip Skip the PR/issue when compiling release notes Team:Docs Team:Observability Team label for Observability Team (for things that are handled across all of observability) v7.16.0 v8.0.0 labels Sep 3, 2021
@lcawl lcawl marked this pull request as ready for review September 3, 2021 16:13
@lcawl lcawl requested review from a team as code owners September 3, 2021 16:13
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-docs (Team:Docs)

@lcawl
Copy link
Contributor Author

lcawl commented Sep 9, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 408.1KB 408.4KB +344.0B
infra 150.4KB 150.2KB -195.0B
total +149.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@lcawl lcawl merged commit 4d933c7 into elastic:master Sep 9, 2021
@lcawl lcawl deleted the infra-links branch September 9, 2021 18:27
lcawl added a commit to lcawl/kibana that referenced this pull request Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result release_note:skip Skip the PR/issue when compiling release notes Team:Docs Team:Observability Team label for Observability Team (for things that are handled across all of observability) v7.16.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants