Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Event Log] Add missing import statement to schema generator template #111955

Merged
merged 1 commit into from
Sep 13, 2021
Merged

[Event Log] Add missing import statement to schema generator template #111955

merged 1 commit into from
Sep 13, 2021

Conversation

xcrzx
Copy link
Contributor

@xcrzx xcrzx commented Sep 13, 2021

Summary

Added missing import semver from 'semver'; to the schema generator template. Without it, running node ./x-pack/plugins/event_log/scripts/create_schemas.js produces a broken generated/schemas.ts artifact.

@xcrzx xcrzx added bug Fixes for quality problems that affect the customer experience v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Feature:EventLog labels Sep 13, 2021
@xcrzx xcrzx requested a review from a team as a code owner September 13, 2021 13:51
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

pmuellr
pmuellr approved these changes Sep 13, 2021
View reviewed changes
Copy link
Member

@pmuellr pmuellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

YulNaumenko
YulNaumenko approved these changes Sep 13, 2021
View reviewed changes
Copy link
Contributor

@YulNaumenko YulNaumenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xcrzx xcrzx merged commit 2bdb313 into elastic:master Sep 13, 2021
@xcrzx xcrzx deleted the fix-event-log-schema-generator branch September 13, 2021 16:40
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 111955 or prevent reminders by adding the backport:skip label.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Sep 15, 2021
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 111955 or prevent reminders by adding the backport:skip label.

5 similar comments
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 111955 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 111955 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 111955 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 111955 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 111955 or prevent reminders by adding the backport:skip label.

@mikecote
Copy link
Contributor

@xcrzx should this PR backport to 7.x or should we add the backport:skip label?

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 111955 or prevent reminders by adding the backport:skip label.

@xcrzx xcrzx mentioned this pull request Sep 27, 2021
Merged
xcrzx added a commit to xcrzx/kibana that referenced this pull request Sep 27, 2021
@xcrzx
Add missing import statement to schema generator template (elastic#11…
70b06d1 
…1955)
xcrzx added a commit that referenced this pull request Sep 27, 2021
@xcrzx
Add missing import statement to schema generator template (#111955) (#…
c24d285 
…113111)
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YulNaumenko YulNaumenko YulNaumenko approved these changes

@pmuellr pmuellr pmuellr approved these changes

Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience Feature:EventLog release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@xcrzx @elasticmachine @kibanamachine @mikecote @pmuellr @YulNaumenko