Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Uptime] Update no data available state #112403

Merged
merged 9 commits into from
Sep 21, 2021
Merged

[Uptime] Update no data available state #112403

merged 9 commits into from
Sep 21, 2021

Conversation

shahzad31
Copy link
Contributor

@shahzad31 shahzad31 commented Sep 16, 2021 •
edited
Loading

Summary

Fix #111389

Update no data check screen for uptime to use commom observability template

New design doesn't covey the index information, which will be probably handled in a follow up https://github.com/elastic/observability-design/issues/98

After:
image

Before:
image

@shahzad31 shahzad31 self-assigned this Sep 16, 2021
@shahzad31 shahzad31 added Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.16.0 v8.0.0 labels Sep 16, 2021
@shahzad31 shahzad31 marked this pull request as ready for review September 20, 2021 11:50
@shahzad31 shahzad31 requested a review from a team as a code owner September 20, 2021 11:50
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@shahzad31 shahzad31 added auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes labels Sep 20, 2021
@shahzad31 shahzad31 mentioned this pull request Sep 20, 2021
Merged
20 tasks
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
uptime 644 640 -4

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
uptime 560.2KB 558.7KB -1.5KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @shahzad31

dominiqueclarke
dominiqueclarke reviewed Sep 20, 2021
View reviewed changes
x-pack/plugins/uptime/public/apps/uptime_page_template.tsx

return (
<>
<div data-test-subj={noDataConfig ? 'data-missing' : undefined} />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this for?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually just used for functional testing purpose. The new component which is coming from KIbanaPageTemplate doesn't expose anything in case of no data. So i kep this dataTestSubject to make tests happy.

Perhapsi can rewrite tests to query by text or other css selectors,

dominiqueclarke
dominiqueclarke approved these changes Sep 20, 2021
View reviewed changes
Copy link
Contributor

@dominiqueclarke dominiqueclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just wondering, do we still want these errors here? Is there a way to opt out of these?
Screen Shot 2021-09-20 at 11 31 47 AM

@shahzad31 shahzad31 merged commit 322c5e2 into elastic:master Sep 21, 2021
@shahzad31 shahzad31 deleted the uptime-no-data-screen branch September 21, 2021 11:15
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 21, 2021
@shahzad31 @kibanamachine
[Uptime] Update no data available state (elastic#112403)
3d09fe0 
* wip

* update component

* update paths

* fix i18n

* fix tests

* revert uneeded
@kibanamachine kibanamachine mentioned this pull request Sep 21, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

@shahzad31
Copy link
Contributor Author

shahzad31 commented Sep 21, 2021 •
edited
Loading

LGTM. Just wondering, do we still want these errors here? Is there a way to opt out of these?
Screen Shot 2021-09-20 at 11 31 47 AM

I honestly think they are helpful, it shows more details, though we can't hide those. I will probably raise a separate issue if it's worth suppressing those somehow.

cc @dominiqueclarke

kibanamachine added a commit that referenced this pull request Sep 21, 2021
@kibanamachine @shahzad31
[Uptime] Update no data available state (#112403) (#112653)
32f490d 
* wip

* update component

* update paths

* fix i18n

* fix tests

* revert uneeded

Co-authored-by: Shahzad <shahzad.muhammad@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominiqueclarke dominiqueclarke dominiqueclarke approved these changes

Assignees

@shahzad31 shahzad31

Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Uptime] Implement “no data” check to drive the “no data screens” for Uptime
4 participants
@shahzad31 @elasticmachine @kibanamachine @dominiqueclarke