Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Stack monitoring] Elasticsearch nodes view migration #112422

Merged
merged 7 commits into from
Sep 23, 2021

Conversation

estermv
Copy link
Contributor

@estermv estermv commented Sep 16, 2021

Summary

This PR is part of #111756

It migrates the Elasticsearch Nodes page to react.

It also adds a hook to manage table pagination.

NOTE: the nodes view should be available when there is no data. This would be covered here

@estermv estermv added v8.0.0 Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services release_note:skip Skip the PR/issue when compiling release notes Feature:Stack Monitoring auto-backport Deprecated - use backport:version if exact versions are needed v7.16.0 Epic: Stack Monitoring de-angularization labels Sep 16, 2021
@estermv estermv requested a review from a team as a code owner September 16, 2021 14:11
@estermv estermv requested review from a team September 16, 2021 14:11
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@neptunian
Copy link
Contributor

neptunian commented Sep 16, 2021

Testing this locally and looks good. Found a couple issues.

  • I have 10 nodes in my cluster. If I select to show only 5 per page and then refresh the page there is no pagination to show my other 5 nodes. Before it would have 2 pages.
  • The filter query bar doesn't seem to be working

@neptunian neptunian self-assigned this Sep 16, 2021
@neptunian neptunian force-pushed the elasticsearch-nodes-view-migration branch from d2a15e9 to 1862306 Compare September 21, 2021 19:54
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
monitoring 582 584 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
monitoring 788.4KB 793.3KB +4.9KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @neptunian

@phillipb
Copy link
Contributor

Not seeing breadcrumbs being updated on that page. Would be something like this:

useEffect(() => {
if (clusters && clusters.length) {
generateBreadcrumbs(clusters[0].cluster_name);
}
}, [clusters, generateBreadcrumbs]);

@neptunian
Copy link
Contributor

@phillipb thanks, it appears to be missing on the elasticsearch overview page as well.

@neptunian
Copy link
Contributor

Discussed with @phillipb it would be easier to add the breadcrumbs all at once so merging without that

@neptunian neptunian merged commit 8a69998 into elastic:master Sep 23, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 23, 2021
* wip nodes view migration

* Save table pagination with localStorage and add some types

* fix types

* fix pagination

* fix table query

* remove async

* fix eslint

Co-authored-by: neptunian <sandra.gonzales@elastic.co>
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Sep 23, 2021
)

* wip nodes view migration

* Save table pagination with localStorage and add some types

* fix types

* fix pagination

* fix table query

* remove async

* fix eslint

Co-authored-by: neptunian <sandra.gonzales@elastic.co>

Co-authored-by: Ester Martí Vilaseca <ester.martivilaseca@elastic.co>
Co-authored-by: neptunian <sandra.gonzales@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Epic: Stack Monitoring de-angularization Feature:Stack Monitoring release_note:skip Skip the PR/issue when compiling release notes Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.16.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants