-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Stack monitoring] Elasticsearch nodes view migration #112422
[Stack monitoring] Elasticsearch nodes view migration #112422
Conversation
Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui) |
Testing this locally and looks good. Found a couple issues.
|
d2a15e9
to
1862306
Compare
x-pack/plugins/monitoring/public/application/hooks/use_table.ts
Outdated
Show resolved
Hide resolved
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: cc @neptunian |
Not seeing breadcrumbs being updated on that page. Would be something like this: kibana/x-pack/plugins/monitoring/public/application/pages/cluster/overview_page.tsx Lines 88 to 92 in a949cc8
|
@phillipb thanks, it appears to be missing on the elasticsearch overview page as well. |
Discussed with @phillipb it would be easier to add the breadcrumbs all at once so merging without that |
* wip nodes view migration * Save table pagination with localStorage and add some types * fix types * fix pagination * fix table query * remove async * fix eslint Co-authored-by: neptunian <sandra.gonzales@elastic.co>
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
) * wip nodes view migration * Save table pagination with localStorage and add some types * fix types * fix pagination * fix table query * remove async * fix eslint Co-authored-by: neptunian <sandra.gonzales@elastic.co> Co-authored-by: Ester Martí Vilaseca <ester.martivilaseca@elastic.co> Co-authored-by: neptunian <sandra.gonzales@elastic.co>
Summary
This PR is part of #111756
It migrates the Elasticsearch Nodes page to react.
It also adds a hook to manage table pagination.
NOTE: the nodes view should be available when there is no data. This would be covered here