[Reporting/Discover/Search Sessions] Only use relative time filter when generating share data #112588

jloleysens · 2021-09-20T17:25:38Z

Summary

After merging #110459 we introduced a regression into restoring search sessions with relative time on discover. This contribution scopes creating a relative time filter to reporting only. This way we preserve the fix for the Copy URL and scheduled reports and address the regression.

Release note

We fixed a bug where restoring search sessions in discover would not preserve absolute times thus invalidate search session caches.

Checklist

Unit or functional tests were updated or added to match the most common scenarios

CC @tsullivan @Dosant @lukasolson @ppisljar

elasticmachine · 2021-09-20T17:25:41Z

Pinging @elastic/kibana-reporting-services (Team:Reporting Services)

elasticmachine · 2021-09-20T17:25:41Z

Pinging @elastic/kibana-app-services (Team:AppServices)

jloleysens · 2021-09-20T17:27:39Z

Input regarding tests to add/update would be much appreciated!

src/plugins/discover/public/application/apps/main/utils/update_search_source.ts

tsullivan

This LGTM. This is the right way to solve this. Much appreciation for jumping on this so quickly!

jloleysens · 2021-09-21T08:12:55Z

@elasticmachine merge upstream

…-for-search-sessions

Co-authored-by: Tim Sullivan <tsullivan@users.noreply.github.com>

Dosant

Checked that restoring relative session works.

There is an existing functional test that should have caught this bug:

kibana/x-pack/test/search_sessions_integration/tests/apps/discover/async_search.ts

Lines 104 to 122 in 0af821a

    
             it('relative timerange works', async () => { 
        
               await PageObjects.common.navigateToApp('discover'); 
        
               await PageObjects.header.waitUntilLoadingHasFinished(); 
        
               await searchSessions.save(); 
        
               await searchSessions.expectState('backgroundCompleted'); 
        
               const searchSessionId = await getSearchSessionId(); 
        
               expect(await PageObjects.discover.hasNoResults()).to.be(true); 
        
               log.info('searchSessionId', searchSessionId); 
        
               // load URL to restore a saved session 
        
               await PageObjects.searchSessionsManagement.goTo(); 
        
               const searchSessionList = await PageObjects.searchSessionsManagement.getList(); 
        
               // navigate to Discover 
        
               await searchSessionList[0].view(); 
        
               await PageObjects.header.waitUntilLoadingHasFinished(); 
        
               await searchSessions.expectState('restored'); 
        
               expect(await PageObjects.discover.hasNoResults()).to.be(true); 
        
             }); 
        
           });

I will check separately why it didn't catch it and will try to fix

Improve discover search session relative time range test

…ingData function

…tes jest tests

kertal

Code LGTM, code owners review, didn't test

tsullivan

LGTM!

We can remove this TODO: 606d1b8#diff-0154cfbb823111800ea5acf098c44670bcf6035935df851983db9f2c55bfe16cR93 but I'll take care of that later.

…en generating share data (elastic#112588) * only use relative time filter when generating share data * Added comment on absolute time filter. Co-authored-by: Tim Sullivan <tsullivan@users.noreply.github.com> * improve discover search session relative time range test * update discover tests and types for passing in data plugin to getSharingData function * updated reporting to pass in data plugin to getSharingData, also updates jest tests Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Tim Sullivan <tsullivan@users.noreply.github.com> Co-authored-by: Anton Dosov <anton.dosov@elastic.co>

kibanamachine · 2021-09-21T19:46:40Z

💔 Backport failed

Status	Branch	Result
✅	7.x
❌	7.14	Commit could not be cherrypicked due to conflicts
❌	7.15	Commit could not be cherrypicked due to conflicts

Successful backport PRs will be merged automatically after passing CI.

To backport manually run:
node scripts/backport --pr 112588

…en generating share data (elastic#112588) * only use relative time filter when generating share data * Added comment on absolute time filter. Co-authored-by: Tim Sullivan <tsullivan@users.noreply.github.com> * improve discover search session relative time range test * update discover tests and types for passing in data plugin to getSharingData function * updated reporting to pass in data plugin to getSharingData, also updates jest tests Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Tim Sullivan <tsullivan@users.noreply.github.com> Co-authored-by: Anton Dosov <anton.dosov@elastic.co>

…en generating share data (#112588) (#112735) * only use relative time filter when generating share data * Added comment on absolute time filter. Co-authored-by: Tim Sullivan <tsullivan@users.noreply.github.com> * improve discover search session relative time range test * update discover tests and types for passing in data plugin to getSharingData function * updated reporting to pass in data plugin to getSharingData, also updates jest tests Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Tim Sullivan <tsullivan@users.noreply.github.com> Co-authored-by: Anton Dosov <anton.dosov@elastic.co> Co-authored-by: Jean-Louis Leysens <jloleysens@gmail.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Anton Dosov <anton.dosov@elastic.co>

…en generating share data (#112588) (#112736) * only use relative time filter when generating share data * Added comment on absolute time filter. Co-authored-by: Tim Sullivan <tsullivan@users.noreply.github.com> * improve discover search session relative time range test * update discover tests and types for passing in data plugin to getSharingData function * updated reporting to pass in data plugin to getSharingData, also updates jest tests Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Tim Sullivan <tsullivan@users.noreply.github.com> Co-authored-by: Anton Dosov <anton.dosov@elastic.co> Co-authored-by: Jean-Louis Leysens <jloleysens@gmail.com> Co-authored-by: Tim Sullivan <tsullivan@users.noreply.github.com> Co-authored-by: Anton Dosov <anton.dosov@elastic.co>

…lter when generating share data (#112588) (#112737) * [Reporting/Discover/Search Sessions] Only use relative time filter when generating share data (#112588) * only use relative time filter when generating share data * Added comment on absolute time filter. Co-authored-by: Tim Sullivan <tsullivan@users.noreply.github.com> * improve discover search session relative time range test * update discover tests and types for passing in data plugin to getSharingData function * updated reporting to pass in data plugin to getSharingData, also updates jest tests Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Tim Sullivan <tsullivan@users.noreply.github.com> Co-authored-by: Anton Dosov <anton.dosov@elastic.co> * fixes * fix ts Co-authored-by: Jean-Louis Leysens <jloleysens@gmail.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Anton Dosov <anton.dosov@elastic.co>

…lter when generating share data (#112588) (#112740) * [Reporting/Discover/Search Sessions] Only use relative time filter when generating share data (#112588) * only use relative time filter when generating share data * Added comment on absolute time filter. Co-authored-by: Tim Sullivan <tsullivan@users.noreply.github.com> * improve discover search session relative time range test * update discover tests and types for passing in data plugin to getSharingData function * updated reporting to pass in data plugin to getSharingData, also updates jest tests Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Tim Sullivan <tsullivan@users.noreply.github.com> Co-authored-by: Anton Dosov <anton.dosov@elastic.co> * fix bad merge * fixes * fix Co-authored-by: Jean-Louis Leysens <jloleysens@gmail.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Anton Dosov <anton.dosov@elastic.co>

kibanamachine · 2021-09-22T09:49:09Z

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`discover`	378.6KB	378.7KB	+177.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`reporting`	40.0KB	40.1KB	+109.0B

History

💚 Build #154516 succeeded 606d1b8
💔 Build #154493 failed 09f031c
💔 Build #154485 failed 9c6fe35
💔 Build #154335 failed 6273d75

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

only use relative time filter when generating share data

6273d75

jloleysens added Feature:Discover Discover Application release_note:fix v8.0.0 Team:AppServices v7.16.0 v7.14.2 v7.15.1 labels Sep 20, 2021

jloleysens requested a review from a team as a code owner September 20, 2021 17:25

jloleysens requested review from kertal and Dosant September 20, 2021 17:25

tsullivan reviewed Sep 20, 2021

View reviewed changes

src/plugins/discover/public/application/apps/main/utils/update_search_source.ts Show resolved Hide resolved

tsullivan approved these changes Sep 20, 2021

View reviewed changes

kibanamachine and others added 2 commits September 21, 2021 04:12

Merge branch 'master' into reporting/discover-fix-relative-time-range…

1ada423

…-for-search-sessions

Added comment on absolute time filter.

9c6fe35

Co-authored-by: Tim Sullivan <tsullivan@users.noreply.github.com>

Dosant approved these changes Sep 21, 2021

View reviewed changes

Dosant and others added 2 commits September 21, 2021 10:47

improve discover search session relative time range test

97aa5f4

Merge pull request #5 from Dosant/d/2021-09-21-discover-relative-test

09f031c

Improve discover search session relative time range test

jloleysens requested a review from a team as a code owner September 21, 2021 08:55

Dosant approved these changes Sep 21, 2021

View reviewed changes

jloleysens added 2 commits September 21, 2021 12:58

update discover tests and types for passing in data plugin to getShar…

a8bff04

…ingData function

updated reporting to pass in data plugin to getSharingData, also upda…

606d1b8

…tes jest tests

jloleysens requested a review from a team as a code owner September 21, 2021 10:59

jloleysens requested a review from tsullivan September 21, 2021 12:35

kertal approved these changes Sep 21, 2021

View reviewed changes

jloleysens mentioned this pull request Sep 21, 2021

[Search Sessions][Discover] Search sessions with relative time range won't restore in discover #112562

Closed

jloleysens added the auto-backport Deprecated - use backport:version if exact versions are needed label Sep 21, 2021

tsullivan approved these changes Sep 21, 2021

View reviewed changes

tsullivan merged commit 25bf795 into elastic:master Sep 21, 2021

tsullivan mentioned this pull request Sep 21, 2021

[7.x] [Reporting/Discover/Search Sessions] Only use relative time filter when generating share data (#112588) #112735

Merged

kibanamachine mentioned this pull request Sep 21, 2021

[7.x] [Reporting/Discover/Search Sessions] Only use relative time filter when generating share data (#112588) #112736

Merged

tsullivan mentioned this pull request Sep 21, 2021

[7.15] [Reporting/Discover/Search Sessions] Only use relative time filter when generating share data (#112588) #112737

Merged

tsullivan mentioned this pull request Sep 21, 2021

[7.14] [Reporting/Discover/Search Sessions] Only use relative time filter when generating share data (#112588) #112740

Merged

jloleysens deleted the reporting/discover-fix-relative-time-range-for-search-sessions branch September 22, 2021 08:14

sophiec20 added the (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead label Aug 21, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Reporting/Discover/Search Sessions] Only use relative time filter when generating share data #112588

[Reporting/Discover/Search Sessions] Only use relative time filter when generating share data #112588

jloleysens commented Sep 20, 2021 •

edited

Loading

elasticmachine commented Sep 20, 2021

elasticmachine commented Sep 20, 2021

jloleysens commented Sep 20, 2021

tsullivan left a comment

jloleysens commented Sep 21, 2021

Dosant left a comment

kertal left a comment

tsullivan left a comment

kibanamachine commented Sep 21, 2021

kibanamachine commented Sep 22, 2021

	it('relative timerange works', async () => {
	await PageObjects.common.navigateToApp('discover');
	await PageObjects.header.waitUntilLoadingHasFinished();
	await searchSessions.save();
	await searchSessions.expectState('backgroundCompleted');
	const searchSessionId = await getSearchSessionId();
	expect(await PageObjects.discover.hasNoResults()).to.be(true);
	log.info('searchSessionId', searchSessionId);

	// load URL to restore a saved session
	await PageObjects.searchSessionsManagement.goTo();
	const searchSessionList = await PageObjects.searchSessionsManagement.getList();
	// navigate to Discover
	await searchSessionList[0].view();
	await PageObjects.header.waitUntilLoadingHasFinished();
	await searchSessions.expectState('restored');
	expect(await PageObjects.discover.hasNoResults()).to.be(true);
	});
	});

[Reporting/Discover/Search Sessions] Only use relative time filter when generating share data #112588

[Reporting/Discover/Search Sessions] Only use relative time filter when generating share data #112588

Conversation

jloleysens commented Sep 20, 2021 • edited Loading

Summary

Release note

Checklist

elasticmachine commented Sep 20, 2021

elasticmachine commented Sep 20, 2021

jloleysens commented Sep 20, 2021

tsullivan left a comment

Choose a reason for hiding this comment

jloleysens commented Sep 21, 2021

Dosant left a comment

Choose a reason for hiding this comment

kertal left a comment

Choose a reason for hiding this comment

tsullivan left a comment

Choose a reason for hiding this comment

kibanamachine commented Sep 21, 2021

💔 Backport failed

kibanamachine commented Sep 22, 2021

💚 Build Succeeded

Metrics [docs]

Async chunks

Page load bundle

History

jloleysens commented Sep 20, 2021 •

edited

Loading