[Reporting] Address Canvas PDF test failing in Cloud #112623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsullivan
added
release_note:skip
clintandrewhall
approved these changes
Sep 21, 2021
| @@ -198,7 +198,8 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { | |||
| " | |||
| `); | |||
|
|
|||
| expect(res.get('content-length')).to.be('20725'); | |||
| const contentLength = parseInt(res.get('content-length'), 10); | |||
| expect(contentLength >= 20725 && contentLength <= 20726).to.be(true); // contentLength can be between 20725 and 20726 | |||
There was a problem hiding this comment.
nit: should these be documented constants, or is this specific to this test?
There was a problem hiding this comment.
This is specific to this test - it's essentially a snapshot of the content length of the downloaded PDF file.
💚 Build SucceededMetrics [docs]
To update your PR or re-run it, just comment with: |
tsullivan
added a commit
to tsullivan/kibana
that referenced
this pull request
Sep 21, 2021
tsullivan
added a commit
to tsullivan/kibana
that referenced
this pull request
Sep 21, 2021
tsullivan
added a commit
to tsullivan/kibana
that referenced
this pull request
Sep 21, 2021
tsullivan
added a commit
that referenced
this pull request
Sep 21, 2021
tsullivan
added a commit
that referenced
this pull request
Sep 21, 2021
tsullivan
added a commit
that referenced
this pull request
Sep 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #87713
Updates the functional test to allow the content length of the downloaded Canvas report to be between 20725 and 20726