Add allowlist filter for Exception list data #112668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjhampton
added
v8.0.0
release_note:skip
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
pjhampton
commented
Sep 21, 2021
x-pack/plugins/security_solution/server/lib/telemetry/tasks/security_lists.ts
Outdated
Show resolved
Hide resolved
|
@elasticmachine merge upstream |
donaherc
reviewed
Sep 21, 2021
| trusted_application: TrustedApp[]; | ||
| endpoint_exception: EndpointExceptionListItem[]; | ||
| endpoint_event_filter: EndpointExceptionListItem[]; | ||
| trusted_application: TelemetryEvent[]; |
There was a problem hiding this comment.
Interesting, why are these types changed to be less concrete?
There was a problem hiding this comment.
Ref this commit: be4c21f
The reasoning around this was 2 fold:
TrustedAppandEndpointExceptionListItem(renamedExceptionListItem) were consolidated, so these would have been 3ExceptionListItem. Using a type we don't own has caused the issue we discussed in the backref issue.- The reason for the cast to
TelemetryEventis to allow for the allow list filtering without overcomplicating the logic or introducing generics (which wouldn't be easy to do / test)
|
Thanks @donaherc. Good q! |
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: cc @pjhampton |
donaherc
approved these changes
Sep 21, 2021
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 21, 2021
* Add allowlist filter to exception list telemetry. * Refactor away union type. * Bump interval back to 24h. Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
💔 Backport failed
Successful backport PRs will be merged automatically after passing CI. To backport manually run: |
kibanamachine
added a commit
that referenced
this pull request
Sep 21, 2021
* Add allowlist filter to exception list telemetry. * Refactor away union type. * Bump interval back to 24h. Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Pete Hampton <pjhampton@users.noreply.github.com>
This was referenced Sep 22, 2021
pjhampton
added a commit
that referenced
this pull request
Sep 22, 2021
* Add allowlist filter for Exception list data (#112668) * Add allowlist filter to exception list telemetry. * Refactor away union type. * Bump interval back to 24h. Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> * Fix linting issue Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Filters out non-required information for downstream analysis.
Checklist
Delete any items that are not applicable to this PR.
For maintainers