Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.x] [Expressions] Fix setup and start contracts (#110841) #112923

Merged
merged 2 commits into from
Sep 23, 2021
Merged

[7.x] [Expressions] Fix setup and start contracts (#110841) #112923

merged 2 commits into from
Sep 23, 2021

Conversation

dokmic
Copy link
Contributor

@dokmic dokmic commented Sep 23, 2021

Backports the following commits to 7.x:

@dokmic
[Expressions] Fix setup and start contracts (elastic#110841)
385cfb6 
* Refactor executor forking to implement state inheritance
* Fix setup and start contracts typings
* Add support of named forks
* Add expressions service life-cycle assertions
@dokmic dokmic enabled auto-merge (squash) September 23, 2021 06:46
@dokmic
Copy link
Contributor Author

dokmic commented Sep 23, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
expressions 1598 1626 +28

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
canvas 1.6MB 1.6MB -31.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
canvas 30.1KB 30.1KB -22.0B
expressions 218.9KB 221.4KB +2.5KB
total +2.5KB
Unknown metric groups

API count

id before after diff
expressions 2036 2072 +36

References to deprecated APIs

id before after diff
canvas 46 64 +18

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dokmic dokmic merged commit 7ce80d5 into elastic:7.x Sep 23, 2021
@dokmic dokmic deleted the backport/7.x/pr-110841 branch September 23, 2021 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dokmic @kibanamachine