-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[uiActionsEnhanced] reduce bundle size #112956
Conversation
Pinging @elastic/kibana-app-services (Team:AppServices) |
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, left a couple of optional nits.
x-pack/plugins/ui_actions_enhanced/public/drilldowns/url_drilldown/url_template.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/ui_actions_enhanced/public/drilldowns/url_drilldown/url_template.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/ui_actions_enhanced/public/drilldowns/url_drilldown/url_template.ts
Outdated
Show resolved
Hide resolved
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / general / X-Pack Reporting Functional Tests With Deprecated Roles config.x-pack/test/reporting_functional/reporting_and_deprecated_security/security_roles_privileges·ts.Reporting Functional Tests with Deprecated Security configuration enabled Security with `reporting_user` built-in role Discover: Generate CSV does allow user with reporting_user roleStandard Out
Stack Trace
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Public APIs missing exports
Page load bundle
Unknown metric groupsAPI count
async chunk count
History
To update your PR or re-run it, just comment with: |
💔 Backport failed
To backport manually run: |
# Conflicts: # packages/kbn-optimizer/limits.yml
Summary
Close #109891
Close #95872
Before
After