Bump prismjs from 1.24.0 to 1.25.0 #113388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
watson
added
v8.0.0
release_note:skip
thompsongl
approved these changes
Sep 30, 2021
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 30, 2021
💔 Backport failed
Successful backport PRs will be merged automatically after passing CI. To backport manually run: |
kibanamachine
added a commit
that referenced
this pull request
Sep 30, 2021
watson
added a commit
to watson/kibana
that referenced
this pull request
Oct 6, 2021
# Conflicts: # package.json
watson
added a commit
to watson/kibana
that referenced
this pull request
Oct 6, 2021
# Conflicts: # package.json # yarn.lock
watson
added a commit
that referenced
this pull request
Oct 6, 2021
watson
added a commit
that referenced
this pull request
Oct 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog for
prismjsv1.25.0: https://github.com/PrismJS/prism/blob/master/CHANGELOG.md#1250-2021-09-16It's hard to see if any of the changes are actually breaking changes. However, I had to use the
resolutionsfield inpackage.jsonto force-upgrade one of our dependencies toprismjs, specifically therefractorpackage, which currently depends on~1.24.0. We have another dependency which uses^1.24.0and so could be upgraded without using theresolutionsfield, so I'm guessing it's ok. That being said, a newer version ofrefractorhave upgraded toprismjsv1.25.0 but the upgrade-commit is quite involved, so it could indicate some sort of issue: wooorm/refractor@175fa9fHopefully any issue will be caught by CI 🤞