-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependency @elastic/elasticsearch to ^8.0.0-canary.22 (master) #113514
Conversation
Pinging @elastic/kibana-core (Team:Core) |
Pinging @elastic/kibana-operations (Team:Operations) |
💔 Build Failed
Failed CI Steps
Metrics [docs]
To update your PR or re-run it, just comment with: |
From the build logs: 11:33:14 info [bazel] packages/kbn-securitysolution-es-utils/src/delete_all_index/index.ts:31:5 - error TS2578: Unused '@ts-expect-error' directive.
11:33:14 info [bazel]
11:33:14 info [bazel] 31 // @ts-expect-error status doesn't exist on response
11:33:14 info [bazel] ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
11:33:14 info [bazel]
11:33:14 info [bazel] packages/kbn-securitysolution-es-utils/src/elasticsearch_client/index.ts:12:35 - error TS2307: Cannot find module '@elastic/elasticsearch/api/kibana' or its corresponding type declarations.
11:33:14 info [bazel]
11:33:14 info [bazel] 12 import type { KibanaClient } from '@elastic/elasticsearch/api/kibana';
11:33:14 info [bazel] ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
11:33:14 info [bazel]
11:33:14 info [bazel] packages/kbn-securitysolution-es-utils/src/elasticsearch_client/index.ts:18:8 - error TS2307: Cannot find module '@elastic/elasticsearch/lib/Transport' or its corresponding type declarations.
11:33:14 info [bazel]
11:33:14 info [bazel] 18 } from '@elastic/elasticsearch/lib/Transport';
11:33:14 info [bazel] ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
11:33:14 info [bazel] The first one is a type fix, which is good, but the second and third errors are types that are no longer here. @delvedor were the types moved elsewhere, or is this more impacting that this? |
@pgayvallet the transport has been moved into its own package: The new Kibana types has been moved here: |
@delvedor Is it a recommended way to import import type {
ApiResponse,
TransportRequestOptions,
TransportRequestParams,
TransportRequestPromise,
--- } from '@elastic/elasticsearch/lib/Transport';
+++ } from '@elastic/elasticsearch'; |
Okay, there are some significant changes in the transport types. Unsure of the amount of work required to get this green. |
Yes, you should import them from that package. Re-exporting could go out of sync, and if you need the transport types, very likely you also need to use something from the transport module in any case. |
Closing. I'm going to work on it in #108387 |
Renovate Ignore NotificationAs this PR has been closed unmerged, Renovate will now ignore this update (^8.0.0-canary.22). You will still receive a PR once a newer version is released, so if you wish to permanently ignore this dependency, please add it to the If this PR was closed by mistake or you changed your mind, you can simply rename this PR and you will soon get a fresh replacement PR opened. |
This PR contains the following updates:
^8.0.0-canary.21
->^8.0.0-canary.22
Release Notes
elastic/elasticsearch-js
v8.0.0-canary.22
Compare Source
Configuration
📅 Schedule: At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by WhiteSource Renovate. View repository job log here.