Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TSVB] Removes unused css #113751

Merged
merged 3 commits into from
Oct 6, 2021
Merged

Conversation

stratoula
Copy link
Contributor

@stratoula stratoula commented Oct 4, 2021

Summary

When this version of EUI #112462 merged into kibana, we noticed that the tabs of TSVB appear a little bit different.

After aligning with the design team, we decided to keep the styles introduced by the EuiTab component. For this reason the vis_picker.scss file is not needed anymore.

We also added size l on the euiTabs of the main Vis picker as they are also acting as the page title. This is how they look now:

image (6)

@stratoula
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
visTypeTimeseries 486.0KB 485.8KB -219.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stratoula stratoula added Feature:TSVB TSVB (Time Series Visual Builder) Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.16.0 v8.0.0 release_note:skip Skip the PR/issue when compiling release notes labels Oct 5, 2021
@stratoula stratoula marked this pull request as ready for review October 5, 2021 07:09
@stratoula stratoula requested review from a team as code owners October 5, 2021 07:09
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors (Team:VisEditors)

Copy link
Contributor

@dej611 dej611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review 👍

Tested in Safari and Firefox, looks much better now 👍

Copy link
Contributor

@mbondyra mbondyra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Chrome 👌🏼

@stratoula stratoula added the auto-backport Deprecated - use backport:version if exact versions are needed label Oct 6, 2021
@stratoula stratoula merged commit 12dcc9e into elastic:master Oct 6, 2021
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Oct 6, 2021
* [TSVB] Removes unused css

* Use size l for the tabs

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Oct 6, 2021
* [TSVB] Removes unused css

* Use size l for the tabs

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:TSVB TSVB (Time Series Visual Builder) release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.16.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants