-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TSVB] Removes unused css #113751
[TSVB] Removes unused css #113751
Conversation
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
Pinging @elastic/kibana-vis-editors (Team:VisEditors) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review 👍
Tested in Safari and Firefox, looks much better now 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on Chrome 👌🏼
* [TSVB] Removes unused css * Use size l for the tabs Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
Summary
When this version of EUI #112462 merged into kibana, we noticed that the tabs of TSVB appear a little bit different.
After aligning with the design team, we decided to keep the styles introduced by the EuiTab component. For this reason the
vis_picker.scss
file is not needed anymore.We also added size
l
on the euiTabs of the main Vis picker as they are also acting as the page title. This is how they look now: