Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Reporting] Breaking: Remove setting for Reporting index #113803

Merged

Conversation

tsullivan
Copy link
Member

Summary

Address #101964 for Reporting

@tsullivan tsullivan requested review from a team as code owners October 4, 2021 16:52
@tsullivan tsullivan added backport:skip This commit does not require backporting Team:AppServicesSv v8.0.0 labels Oct 4, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-reporting-services (Team:Reporting Services)

@tsullivan tsullivan added Breaking Change release_note:skip Skip the PR/issue when compiling release notes labels Oct 4, 2021
@tsullivan tsullivan force-pushed the reporting/index-setting-removal branch from e0ee54e to 20eb83b Compare October 4, 2021 16:57
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
reporting 40.8KB 40.9KB +72.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@jloleysens jloleysens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not test locally but these changes look good to me 🍻

Couple of questions:

  1. Do we have telemetry on how often this setting is being used in the wild?
  2. How are we helping "broken" users to migrate?

@tsullivan
Copy link
Member Author

tsullivan commented Oct 5, 2021

Do we have telemetry on how often this setting is being used in the wild?

@jloleysens we do NOT have telemetry to see how often this setting is used. The meta issue on this is here: #82020 I presume this is a high-visibility breaking change as it affects other plugins as well.

How are we helping "broken" users to migrate

Spaces should be used when multitenancy is needed. The system indices were customizable in 7.x, which is the same release cycle that introduced Spaces.

From the meta issue:

Using saved-object management, a user is able to export all of the saved-objects from a legacy multitenant instance to a Space in the default tenant. However, there are currently some Kibana entities that can't be exported and imported using saved-object management. If we're going to no longer allow users to utilize legacy multitenancy, we should provide them a method of transitioning to Spaces, and as such, we'll need to ensure that users have a clear migration path.

This is an issue for Reporting: reports are not importable into Kibana. The only way a user will be able to view historical reports that were in a custom index is to download them to another form of storage before upgrading to 8.0.

@tsullivan tsullivan merged commit e55593f into elastic:master Oct 5, 2021
@tsullivan tsullivan deleted the reporting/index-setting-removal branch October 5, 2021 18:21
@tsullivan
Copy link
Member Author

Thread on this topic: #82020 (comment)

@sophiec20 sophiec20 added the (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead label Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Breaking Change (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead release_note:skip Skip the PR/issue when compiling release notes v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants