-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Monitoring] Migrate Elasticsearch ML Jobs View from Angular #113974
Conversation
# Conflicts: # x-pack/plugins/monitoring/public/application/index.tsx
Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui) |
Testing (via docker-test-cluster)Unsure if docker-test-cluster supports ML jobs. Will find out :)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gonna say this is good. I can't seem to get jobs to stay open so I think I'm missing a section of functionality. I'll start a cloud cluster and try the testing there to see if I can reach the node screens.
The angular app seems to lack pagination and throws console errors when sorting. So I'd say we're ahead of the game already.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See screenshot. Would probably be good to fix that first. Otherwise this looks awesome.
@matschaffer Turns out this bug also exists in the Angular version, so that's fun. Should I try to fix it in this PR or just merge and open a new issue for it? |
If it exists in angular I think its fine to open a new PR unless you prefer to do it here. |
@neptunian @matschaffer Actually turned out to be a relatively simple fix |
# Conflicts: # x-pack/plugins/monitoring/public/application/index.tsx
💚 Build SucceededMetrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
…#113974) * [Monitoring] Migrate Elasticsearch ML Jobs View from Angular * Add types * Fix broken node links
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
#114176) * [Monitoring] Migrate Elasticsearch ML Jobs View from Angular * Add types * Fix broken node links Co-authored-by: Zacqary Adam Xeper <Zacqary@users.noreply.github.com>
Summary
Closes #113646
Migrates the Elasticsearch/Machine Learning Jobs view to React.
This required me to create a new
ElasticsearchMLJobs
React component, as the Angular view uses its own unique directive for unclear reasons and didn't follow the standard of other views.To test:
monitoring.ui.render_react_app: true