[RAC] create functional tests for add to case #114075

mgiota · 2021-10-06T10:36:38Z

Fixes #110642

Notes for the reviewer

This PR doesn't include tests for checking that rules behave the same when created from either within the solution or from the central rule management screen. I had a few ideas/questions there, we could further discuss if we want to include this in this PR cc @weltenwort
This is not part of this PR, but if time allows I would like a comment regarding an issue I faced and how we could fix this in the future. I was trying to refactor observability service and move workflowStatus related stuff to another file. Apparently what I tried to do is not possible, because I ended up getting a Circular reference to Service(observability). Example code and the error I got can be found here mgiota@d8405f9#r57919232

elasticmachine · 2021-10-12T17:49:36Z

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

mgiota · 2021-10-13T06:59:31Z

@elasticmachine merge upstream

cnasikas

Cases changes LGTM

weltenwort

looks good 👍 I left only a few minor questions below.

x-pack/test/functional/services/observability/alerts/common.ts

weltenwort · 2021-10-13T10:29:18Z

x-pack/test/functional/services/observability/alerts/add_to_case.ts

+const CREATE_CASE_FLYOUT = 'create-case-flyout';
+const SELECT_CASE_MODAL = 'all-cases-modal';
+
+export function ObservabilityAlertsAddToCaseProvider({ getService }: FtrProviderContext) {


If you want to access functions from common in here you could just inject them as an additional parameter. As you discovered, getService('observability') doesn't work here because this code is executed in order to construct that exact service.

weltenwort · 2021-10-13T10:31:28Z

x-pack/test/observability_functional/apps/observability/alerts/add_to_case.ts

+
+      it('opens a flyout when Add to new case is clicked', async () => {
+        await retry.try(async () => {
+          await observability.alerts.common.openActionsMenuForRow(0);


Isn't the menu already open from the previous step?

Good catch! Actually removing this line of code also fixed the issue you mentioned below (click being part of the retry). Now I moved click outside of the retry and everything works like a charm!

weltenwort · 2021-10-13T10:32:14Z

x-pack/test/observability_functional/apps/observability/alerts/add_to_case.ts

+      it('opens a flyout when Add to new case is clicked', async () => {
+        await retry.try(async () => {
+          await observability.alerts.common.openActionsMenuForRow(0);
+          await observability.alerts.addToCase.addToNewCaseButtonClick();


Should this click be part of the retry? Do we want to try clicking repeatedly?

In the beginning I didn't have it as part of the retry and the test was failing. By moving it inside the retry, test stopped failing, but what I noticed in the browser is a long delay between clicking on the menu item and opening the flyout. I will try one more time to move it outside of the retry and see what happens

I tested again and if click is in not part of the retry test fails. I get debg finding element 'By(css selector, [data-test-subj="add-new-case-item"])' again, 2 attempts left │ debg --- retry.try error: no such element: Unable to locate element: {"method":"css selector","selector":"[data-test-subj="add-new-case-item"]"}, because the overflow closes immediately and it can not find the element. I will leave it here for now and I could investigate again.

Update: I moved it out of the retry. See my comment above

x-pack/test/observability_functional/apps/observability/alerts/add_to_case.ts

mgiota · 2021-10-15T07:03:12Z

@elasticmachine merge upstream

kibanamachine · 2021-10-15T09:07:44Z

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`timelines`	240.3KB	240.3KB	-10.0B

History

💔 Build #161268 failed f9b8dff
💚 Build #160320 succeeded 012dd9d
💔 Build #160246 failed 5664199
💛 Build #159891 was flaky b9649ba
💔 Build #159888 failed b4565d6

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @mgiota

* [RAC] create functional tests for add to case * use observability test helpers for user creation * basic tests for add to case options * add two more cases * test case for clicking on add to new case button * remove unused expect statement * clicking on add to existing case should open a modal * move add to case functionality in a separate file * address comments in the PR review Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

kibanamachine · 2021-10-15T09:11:34Z

💚 Backport successful

Status	Branch	Result
✅	7.x

This backport PR will be merged automatically after passing CI.

* [RAC] create functional tests for add to case * use observability test helpers for user creation * basic tests for add to case options * add two more cases * test case for clicking on add to new case button * remove unused expect statement * clicking on add to existing case should open a modal * move add to case functionality in a separate file * address comments in the PR review Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: mgiota <giota85@gmail.com>

## Summary Fixes flake cypress test Fixes #115245 See also: #114075, #115245 ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios

## Summary Fixes flake cypress test Fixes elastic#115245 See also: elastic#114075, elastic#115245 ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios

## Summary Fixes flake cypress test Fixes #115245 See also: #114075, #115245 ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios Co-authored-by: Frank Hassanabad <frank.hassanabad@elastic.co>

mgiota added 2 commits October 11, 2021 21:50

[RAC] create functional tests for add to case

3dc63e2

use observability test helpers for user creation

5b1d489

mgiota force-pushed the 110642_functional_tests_add_to_case branch from 8b78bda to 5b1d489 Compare October 11, 2021 21:06

basic tests for add to case options

e35d639

mgiota added Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services Theme: rac label obsolete v7.16.0 auto-backport Deprecated - use backport:version if exact versions are needed v8.0.0 labels Oct 12, 2021

mgiota self-assigned this Oct 12, 2021

mgiota added 4 commits October 12, 2021 09:46

add two more cases

ff64372

test case for clicking on add to new case button

40b847d

remove unused expect statement

b4565d6

clicking on add to existing case should open a modal

b9649ba

mgiota marked this pull request as ready for review October 12, 2021 17:49

mgiota requested a review from a team as a code owner October 12, 2021 17:49

mgiota marked this pull request as draft October 12, 2021 17:50

move add to case functionality in a separate file

5664199

Merge branch 'master' into 110642_functional_tests_add_to_case

012dd9d

mgiota marked this pull request as ready for review October 13, 2021 06:59

mgiota added the release_note:skip Skip the PR/issue when compiling release notes label Oct 13, 2021

cnasikas approved these changes Oct 13, 2021

View reviewed changes

weltenwort self-requested a review October 13, 2021 10:18

weltenwort reviewed Oct 13, 2021

View reviewed changes

address comments in the PR review

f9b8dff

mgiota enabled auto-merge (squash) October 15, 2021 06:07

Merge branch 'master' into 110642_functional_tests_add_to_case

7bbf4d2

mgiota merged commit c11b38d into elastic:master Oct 15, 2021

kibanamachine mentioned this pull request Oct 15, 2021

[7.x] [RAC] create functional tests for add to case (#114075) #115155

Merged

FrankHassanabad mentioned this pull request Oct 15, 2021

[Security Solution] Fixes flake cypress test #115270

Merged

1 task

mgiota deleted the 110642_functional_tests_add_to_case branch January 4, 2022 10:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[RAC] create functional tests for add to case #114075

[RAC] create functional tests for add to case #114075

mgiota commented Oct 6, 2021 •

edited

Loading

elasticmachine commented Oct 12, 2021

mgiota commented Oct 13, 2021

cnasikas left a comment

weltenwort left a comment

weltenwort Oct 13, 2021

weltenwort Oct 13, 2021

mgiota Oct 15, 2021

weltenwort Oct 13, 2021

mgiota Oct 13, 2021

mgiota Oct 15, 2021

mgiota Oct 15, 2021

mgiota commented Oct 15, 2021

kibanamachine commented Oct 15, 2021

kibanamachine commented Oct 15, 2021

[RAC] create functional tests for add to case #114075

[RAC] create functional tests for add to case #114075

Conversation

mgiota commented Oct 6, 2021 • edited Loading

Notes for the reviewer

elasticmachine commented Oct 12, 2021

mgiota commented Oct 13, 2021

cnasikas left a comment

Choose a reason for hiding this comment

weltenwort left a comment

Choose a reason for hiding this comment

weltenwort Oct 13, 2021

Choose a reason for hiding this comment

weltenwort Oct 13, 2021

Choose a reason for hiding this comment

mgiota Oct 15, 2021

Choose a reason for hiding this comment

weltenwort Oct 13, 2021

Choose a reason for hiding this comment

mgiota Oct 13, 2021

Choose a reason for hiding this comment

mgiota Oct 15, 2021

Choose a reason for hiding this comment

mgiota Oct 15, 2021

Choose a reason for hiding this comment

mgiota commented Oct 15, 2021

kibanamachine commented Oct 15, 2021

💚 Build Succeeded

Metrics [docs]

Async chunks

History

kibanamachine commented Oct 15, 2021

💚 Backport successful

mgiota commented Oct 6, 2021 •

edited

Loading