[Discover] Enable description for saved search modal #114257
Conversation
dimaanj
added
Feature:Discover
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
dimaanj
changed the title
|
@elasticmachine merge upstream |
| 'Save your Discover search so you can use it in visualizations and dashboards', | ||
| })} | ||
| showDescription={false} | ||
| showDescription={true} |
There was a problem hiding this comment.
there's something odd here in the underlying component, so you could just display a general description on top of the form, or enable the description form element. I wonder why?? since having a description on top like it was before can be helpful. dear @timroes, do you know why it was built that way?
Code LGTM, else, just wanted to clarify this, since we remove stuff here.
There was a problem hiding this comment.
I don't think there was any logical reason if this is an explicit OR for those two. I think we can address that, if we would like to show both. But since none of the other save dialogs have a description in it, I'd actually be fine also removing it in Discover. I think it makes more sense having an aligned experience here.
There was a problem hiding this comment.
Fine with that aligning stuff. But one other thought about that. If we enable the description here, we should also show it somewhere? Else we allow user input of something that is just visible on saving.
There was a problem hiding this comment.
I guess it should be visible when inspecting saved object in stack management.
There was a problem hiding this comment.
I believe -untested - it will also automatically already show on dashboard for that panel. But I totally agree it would be better if we also show it in Discover. Though I am not sure if it makes sense to address that without a general change of our loading/listing page, which we revently discussed, i.e. not sure if it's worth spending the time now building the description into the open panel as it is today.
There was a problem hiding this comment.
Discussed this offline, just for posterity: we would like to add the description, and make sure that the description is shown on dashboards the same as for the visualize_embeddable. This does not seem to work out of the box, so we need to check how to get it showing up on panels :)
…e-description-for-ss-modal # Conflicts: # src/plugins/discover/public/application/apps/main/components/top_nav/on_save_search.tsx
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
dimaanj
added
the
auto-backport
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @dmitriynj |
* [Discover] enable description for saved search * [Discover] remove i18n translations for removed description * [Discover] apply Tim's suggestion * [Discover] update snapshot * [Discover] reorder top nav buttons in tests * [Description] fix description save action Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
* [Discover] enable description for saved search * [Discover] remove i18n translations for removed description * [Discover] apply Tim's suggestion * [Discover] update snapshot * [Discover] reorder top nav buttons in tests * [Description] fix description save action Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Dmitry Tomashevich <39378793+Dmitriynj@users.noreply.github.com>
Summary
Closes #110667
This PR enables description for saved search modal.
Top nav buttons
Saved search modal