Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] Legacy url conflict UI improvements (#114172) #114382

Merged
merged 4 commits into from
Oct 9, 2021

Conversation

jportner
Copy link
Contributor

@jportner jportner commented Oct 8, 2021

Backports the following commits to 7.x:

# Conflicts:
#	docs/development/core/public/kibana-plugin-core-public.doclinksstart.md
@jportner jportner enabled auto-merge (squash) October 8, 2021 03:37
@jportner
Copy link
Contributor Author

jportner commented Oct 8, 2021

@elasticmachine merge upstream

@jportner
Copy link
Contributor Author

jportner commented Oct 8, 2021

@elasticmachine merge upstream

@jportner
Copy link
Contributor Author

jportner commented Oct 9, 2021

Need #114411 to merge first before this will pass CI

@jportner
Copy link
Contributor Author

jportner commented Oct 9, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
spaces 241 239 -2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.0MB 1.0MB -104.0B
maps 2.7MB 2.7MB -117.0B
spaces 164.0KB 164.6KB +557.0B
total +336.0B

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
spaces 2 1 -1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 300.7KB 300.8KB +144.0B
spaces 20.4KB 20.4KB -35.0B
total +109.0B
Unknown metric groups

API count

id before after diff
spaces 205 208 +3

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jportner jportner merged commit 7053f5b into elastic:7.x Oct 9, 2021
@jportner jportner deleted the backport/7.x/pr-114172 branch October 9, 2021 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants