Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet] Fix previous configuration modal title #114475

Merged
merged 3 commits into from
Oct 11, 2021
Merged

[Fleet] Fix previous configuration modal title #114475

merged 3 commits into from
Oct 11, 2021

Conversation

kpollich
Copy link
Member

Summary

Fixes #114463

Fix "package policy" -> "integration policy" in previous configuration modal.

@kpollich kpollich added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team auto-backport Deprecated - use backport:version if exact versions are needed v7.16.0 labels Oct 11, 2021
@kpollich kpollich self-assigned this Oct 11, 2021
@kpollich kpollich requested a review from a team as a code owner October 11, 2021 12:21
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

criamico
criamico approved these changes Oct 11, 2021
View reviewed changes
Copy link
Contributor

@criamico criamico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kpollich kpollich enabled auto-merge (squash) October 11, 2021 13:12
@kpollich
Copy link
Member Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 625.7KB 625.7KB +4.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @kpollich

@kpollich kpollich merged commit 32e00f1 into elastic:master Oct 11, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 11, 2021
@kpollich @kibanamachine
[Fleet] Fix previous configuration modal title (elastic#114475)
065a117 
* Fix previous configuration modal title

* Revert translation
@kibanamachine kibanamachine mentioned this pull request Oct 11, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

@kpollich kpollich deleted the 114463-fix-previous-policy-title branch October 11, 2021 16:00
kibanamachine added a commit that referenced this pull request Oct 11, 2021
@kibanamachine @kpollich
[Fleet] Fix previous configuration modal title (#114475) (#114519)
ed48b11 
* Fix previous configuration modal title

* Revert translation

Co-authored-by: Kyle Pollich <kyle.pollich@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@criamico criamico criamico approved these changes

Assignees

@kpollich kpollich

Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
4 participants
@kpollich @elasticmachine @kibanamachine @criamico