Removes deprecated telemetry.url and telemetry.optInStatusUrl from telemetry plugin config #114737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lemetry plugin config
TinaHeiligers
added
backport:skip
TinaHeiligers
commented
Oct 13, 2021
TinaHeiligers
commented
Oct 13, 2021
| /** | ||
| * config options opt into telemetry | ||
| */ | ||
| export const CONFIG_TELEMETRY = 'telemetry:optIn'; |
There was a problem hiding this comment.
No longer supported.
TinaHeiligers
commented
Oct 13, 2021
| * config description for opting into telemetry | ||
| */ | ||
| export const getConfigTelemetryDesc = () => { | ||
| // Can't find where it's used but copying it over from the legacy code just in case... |
There was a problem hiding this comment.
As the comment says, the translation doesn't seem to be used anywhere.
TinaHeiligers
commented
Oct 13, 2021
| this.handleOldUiSettings(uiSettings); | ||
| this.startFetcherWhenOldSettingsAreHandled(core, telemetryCollectionManager); | ||
| // Not catching nor awaiting this promise because it should never reject | ||
| this.startFetcher(core, telemetryCollectionManager); |
There was a problem hiding this comment.
Not strictly needed but we're removing handling the old settings and the old name didn't make sense anymore.
TinaHeiligers
commented
Oct 13, 2021
| core: CoreStart, | ||
| telemetryCollectionManager: TelemetryCollectionManagerPluginStart | ||
| ) { | ||
| await this.oldUiSettingsHandled$.pipe(take(1)).toPromise(); // Wait for the old settings to be handled | ||
| // We start the fetcher having updated everything we need to using the config settings |
There was a problem hiding this comment.
Not strictly needed but the wording wouldn't have made sense anymore.
TinaHeiligers
commented
Oct 13, 2021
| @@ -42,7 +42,6 @@ export default async function ({ readConfigFile }) { | |||
| defaults: { | |||
| 'accessibility:disableAnimations': true, | |||
| 'dateFormat:tz': 'UTC', | |||
| 'telemetry:optIn': false, | |||
There was a problem hiding this comment.
removed support for uiSetting
|
@elasticmachine merge upstream |
TinaHeiligers
commented
Oct 14, 2021
src/core/server/saved_objects/migrationsv2/integration_tests/batch_size_bytes.test.ts
Show resolved
Hide resolved
|
Pinging @elastic/kibana-core (Team:Core) |
|
@elasticmachine merge upstream |
jbudz
approved these changes
Oct 14, 2021
mshustov
approved these changes
Oct 15, 2021
src/core/server/saved_objects/migrationsv2/integration_tests/batch_size_bytes.test.ts
Show resolved
Hide resolved
Bamieh
approved these changes
Oct 15, 2021
rudolf
approved these changes
Oct 15, 2021
src/core/server/saved_objects/migrationsv2/integration_tests/batch_size_bytes.test.ts
Show resolved
Hide resolved
💚 Build SucceededMetrics [docs]Page load bundle
History
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Telemetry urls configured via
uiSettingswere deprecated in favor of atelemetry.sendUsageToconfig setting in #107396.We were also still supporting old configurations from
uiSettings(telemetry:optInandxPackMonitoring:allowReport) in parallel with the new configuration using saved objects.This PR handles removing support for those settings from 8.0, adds to the 8.0
uiSettingsmigration to removetelemetry:optInandxPackMonitoring:allowReportand cleans up code related to handling legacy configurations.Resolves #82432 and cleanup task from #96761
Checklist
Delete any items that are not applicable to this PR.
For maintainers
To reviewers:
These settings are for internal use only and the breaking change isn't end-user facing, hence no release note.