Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.x] [Discover] Removing SavedObject usage for savedSearch (#112983) #114767

Merged
merged 3 commits into from
Oct 13, 2021
Merged

[7.x] [Discover] Removing SavedObject usage for savedSearch (#112983) #114767

merged 3 commits into from
Oct 13, 2021

Conversation

alexwizp
Copy link
Contributor

Backports the following commits to 7.x:

@alexwizp
[Discover] Removing SavedObject usage for savedSearch (elastic#112983)
d0e7c42 
* [Discover] Step 2 - remove SavedObjectLoader

* Fix PR comments

* fix test names

* fix ts error

* add handling of missed 'so'

* add Embeddable error

* fix jest

* add DiscoverError component

* fix Joe comments

* add search params

* add throwErrorOnUrlConflict util method

* add error handling into transform plugin

* do some updates

* add spaces into visualize, visualizations

* fix Tim's comment

* pass false into createGetterSetter for getSpaces

* Fix comments

* Fix lint

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Uladzislau Lasitsa <Uladzislau_Lasitsa@epam.com>
# Conflicts:
#	src/plugins/discover/public/application/apps/context/services/context.ts
@alexwizp alexwizp enabled auto-merge (squash) October 13, 2021 09:03
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
discover 394 399 +5

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
discover 56 77 +21

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
discover 328.0KB 328.8KB +770.0B
transform 322.1KB 322.3KB +183.0B
visDefaultEditor 152.6KB 152.7KB +33.0B
visualizations 72.7KB 72.8KB +134.0B
visualize 53.1KB 53.1KB +36.0B
total +1.1KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
discover 6 7 +1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
discover 19.6KB 23.6KB +4.0KB
reporting 40.9KB 40.9KB +4.0B
savedObjectsManagement 23.2KB 23.2KB +9.0B
visDefaultEditor 19.2KB 19.3KB +138.0B
visualizations 39.0KB 38.9KB -107.0B
total +4.0KB
Unknown metric groups

API count

id before after diff
discover 82 103 +21

References to deprecated APIs

id before after diff
discover 1790 1787 -3
visDefaultEditor 223 213 -10
visualize 99 86 -13
total -26

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@alexwizp alexwizp merged commit d58b14c into elastic:7.x Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexwizp @kibanamachine