[Stack management apps] Deprecate "enabled" Kibana setting #114768

sebelga · 2021-10-13T09:27:57Z

In 8.0 we deprecate the enabled Kibana settings for the apps. As we want to offer an alternative way for our users to disable the UI we had 2 options: add the stack management app to Features control or use another Kibana setting (ui.enabled) for that purpose. The former would be the ideal way as it is the easiest and can be done through our UI. Unfortunately the Features control does not support yet disabling apps that depend on ES privileges so the security team has opened an issue to solve that.

In the meantime we are going to rely on the ui.enabled Kibana setting to let our users disable the UI of our apps.
Some of our apps already use this setting (CCR, ILM, license management, remote clusters) so for those ones I've only added the deprecation notice for UA. For the rest of our apps I have added the ui.enabled setting to the plugin config.

Notes on implementation

As I mentioned several times I like the idea of having the same code base in master and 7.x. The reasons are:

It simplifies the DX. I always work on master and can test different behaviours on 7.x by changing 1 constant
It avoids regression or forgetting bringing back code from 7.x to master (when working against 7.x), like we had to do in Partial forward-port of dacf0c2a6cabf088b0f17f4eca57e01c466286c0. #113672 and [Upgrade Assistant] Forwardport from 7.x #114966
It is more efficient. There is no need to create multiple PRs, working on different master branch and bootstrap Kibana (which we all know can take above 20 min between yarn kbn bootstrap and yarn start)
It avoids merge conflict and (again) regressions. If we work on 7.x and modify a component we won't ever be able to automatically backport that component from master after that. We'll need to manually backport the change and remember why 7.x is different and be sure to keep the change in place. Sure tests should have our back but it is not a fun process. Specially if the component is big and is not in our domain expertise.
It is explicit. The code is the documentation. No need to add bunch of comments here and there. I read the code, I know what behaviour is in 7.x and what is in other majors.
It seems that an approach like this one is a step in the direction of "make it minor" where we might have different "breaking" behaviour between 2 minors that our apps need to handle gracefully for our users. We want to be able to do that without juggling between branches (and again avoid regression in the process).

How to test

Note I have aligned all apps to the same naming convention (using the MAJOR_VERSION const) and file structure (expose that constant from the common folder, handle all the plugin config from inside the ./server/config.ts file).

Add the enabled (e.g. xpack.index_management.enabled: false) setting in kibana.yml and check that the server throws an error
Change that setting to ui.enabled. The server restarts and the UI is not there
Change the MAJOR_VERSION const (in the common folder) to 7.16.0 (the minor does not matter).
The app UI should still not show
Change back the ui.enabled setting to enabled. This time the server should not throw (we are simulating being on 7.16.0) and the UI should be disabled
Open x-pack/plugins/upgrade_assistant/public/plugin.ts and change L64 (replace readonly with false)
Open Upgrade assistant UI. You should see the deprecation for the enabled setting.
Repeat for all the apps.

Test Console

Console expose a URL locator to other apps to link to it. If console UI is disabled the apps linking to it should not display the console button.

Set console.ui.enabled: false in the kibana.yml
Navigate to the home page. You should not see "Dev tools" in the right side menu under "Management"

From home navigate to "Analytics". Again here you should not see the "Dev tools" button

Open src/plugins/kibana_overview/public/components/overview/overview.tsx and change L212 (solutions.length ? to false).
You should now see in the home page the "Manage your data" section. Make sure that "Interact with the Elasticsearch API" is not there.

Navigate to a dashboard and inspect one of the visualization

Select "View: requests" the dropdown > Under the the "Request" tab you should not see the "Open in console" button

Improve console.proxyConfig and `console.proxyFilter` warning

As we are very close to FF I've added 6813c6a to improve the deprecation message for the console.proxyConfig and console.proxyFilter settings.

Fixes #112605
Fixes #113810

sebelga · 2021-10-13T12:45:15Z

x-pack/plugins/upgrade_assistant/server/config.ts

+      return completeConfig;
+    }
+
+    addDeprecation({


In theory this does not make sense as if UA is disabled then it won't be able to surface its own deprecated settings. I decided to put it anyway to align with all the other apps in case there are, in the future, other consumers of the Deprecation service.

elasticmachine · 2021-10-14T13:15:24Z

Pinging @elastic/kibana-stack-management (Team:Stack Management)

sebelga · 2021-10-18T12:29:23Z

Devtools is indeed just a holder for our apps (Console, painless lab, grok debugger, search profiler).

there's nothing stopping you from adding a "Console" sub-feature privilege.

I am confused as I thought you said that our apps could not be added to features control as they rely on ES privileges. Is console an exception?

legrego · 2021-10-18T12:43:00Z

Devtools is indeed just a holder for our apps (Console, painless lab, grok debugger, search profiler).

there's nothing stopping you from adding a "Console" sub-feature privilege.

I am confused as I thought you said that our apps could not be added to features control as they rely on ES privileges. Is console an exception?

Dev Tools is a bit of a special case. Well, Console specifically (I don't know the other apps well enough). Console is effectively a friendly proxy to ES -- it doesn't require any specific ES privileges to run; It'll just use whatever privileges the current user has.

We added Dev Tools as a Kibana feature privilege in case administrators wanted to prevent their users from running arbitrary commands against ES, even if they were otherwise authorized to do so from ES's perspective. We enforce this authorization by registering an access tag on the console route:

kibana/src/plugins/console/server/routes/api/console/proxy/index.ts

Lines 14 to 29 in 4584a8b

    
           export const registerProxyRoute = (deps: RouteDependencies) => { 
        
             deps.router.post( 
        
               { 
        
                 path: '/api/console/proxy', 
        
                 options: { 
        
                   tags: ['access:console'], 
        
                   body: { 
        
                     output: 'stream', 
        
                     parse: false, 
        
                   }, 
        
                 }, 
        
                 validate: routeValidationConfig, 
        
               }, 
        
               createHandler(deps) 
        
             ); 
        
           };

sebelga · 2021-10-18T13:10:31Z

Thanks for the explanation @legrego. As we are very close to FF we are going to keep using the console.ui.enabled setting for this coming major and will align all of our apps to feature control once security is ready for that. Cheers! 👍

…Filter (fixes elastic#113810)

…belga/kibana into stack-managment-apps-deprecate-enable

sebelga · 2021-10-18T13:36:28Z

I've added 6813c6a to this PR as we are very close to FF. It fixes #113810.

Feel free to commit directly to this branch for any suggestion to improve the warning messages.

sebelga · 2021-10-18T13:59:31Z

I've added the missing doc for <app>ui.enabled in 83e0a7b.

Dosant

app services src/plugins/inspector/public/views/requests/components/details/req_code_viewer.tsx lgtm

yuliacech

Hi @sebelga, thank you so much for adding ui.enabled setting to all of our apps, impressive job! I tested locally and haven't noticed any problems with plugins.
The slm_ui.enabled config in Snapshot & Restore disables snapshot policies tab and api routes, but I couldn't find it in the docs. I'm wondering now that we have the ui.enabled config if the slm_ui.enabled config should either be deleted or added to the docs as an alternative to ui.enabled, wdyt? But that's non-blocking for this PR.

* Fix copy * Configure level

* Clarify distinction between Dev Tools and Console.

cjcenizal

Thanks for covering the edge cases in which other plugins link to Console! I didn't test those locally but the code and screenshots LGTM.

I pushed a few changes to copy, docs, and comments. Regarding slm_ui.enabled, I'm not sure if it's worth documenting but I don't think we should remove it. Removing it won't offer any benefits to the user and it will incur the cost of another deprecation, so not worth it IMO.

@sebelga Once you merge this, please ping me for a review of the backport so I can test this in the 7.16 Upgrade Assistant UI, which is significantly different from the UI on master. I'd like to take responsibility for merging the backport once it's gone green.

cjcenizal · 2021-10-18T23:30:18Z

@elasticmachine merge upstream

cjcenizal · 2021-10-19T02:11:46Z

@elasticmachine merge upstream

sebelga · 2021-10-19T10:30:58Z

Thanks for the review @cjcenizal @yuliacech and @sabarasaba !

please ping me for a review of the backport so I can test this in the 7.16 Upgrade Assistant UI, which is significantly different from the UI on master.

ok 👍

…14768) # Conflicts: # docs/dev-tools/console/console.asciidoc # docs/setup/settings.asciidoc # x-pack/plugins/upgrade_assistant/__jest__/client_integration/helpers/index.ts # x-pack/plugins/upgrade_assistant/__jest__/client_integration/helpers/setup_environment.tsx # x-pack/plugins/upgrade_assistant/__jest__/client_integration/overview/overview.test.tsx # x-pack/plugins/upgrade_assistant/common/config.ts # x-pack/plugins/upgrade_assistant/common/constants.ts # x-pack/plugins/upgrade_assistant/public/application/components/es_deprecations/deprecation_types/reindex/flyout/warning_step.test.tsx # x-pack/plugins/upgrade_assistant/public/plugin.ts # x-pack/plugins/upgrade_assistant/public/types.ts

kibanamachine · 2021-10-19T12:44:03Z

💛 Build succeeded, but was flaky

continuous-integration/kibana-ci/pull-request
Commit: d5e7e16
Storybooks Preview
Documentation Changes
Flaky suites:
- xpack-kibana-ciGroup6

Test Failures

Kibana Pipeline / general / X-Pack API Integration Tests.x-pack/test/api_integration/apis/ml/jobs/categorization_field_examples·ts.apis Machine Learning jobs Categorization example endpoint - invalid, too many tokens.

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

[00:00:00]     │
[00:00:00]       └-: apis
[00:00:00]         └-> "before all" hook in "apis"
[00:10:55]         └-: Machine Learning
[00:10:55]           └-> "before all" hook in "Machine Learning"
[00:10:55]           └-> "before all" hook in "Machine Learning"
[00:10:55]             │ debg creating role ft_ml_source
[00:10:55]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [ft_ml_source]
[00:10:55]             │ debg creating role ft_ml_source_readonly
[00:10:55]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [ft_ml_source_readonly]
[00:10:55]             │ debg creating role ft_ml_dest
[00:10:55]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [ft_ml_dest]
[00:10:55]             │ debg creating role ft_ml_dest_readonly
[00:10:55]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [ft_ml_dest_readonly]
[00:10:55]             │ debg creating role ft_ml_ui_extras
[00:10:55]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [ft_ml_ui_extras]
[00:10:55]             │ debg creating role ft_default_space_ml_all
[00:10:55]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [ft_default_space_ml_all]
[00:10:55]             │ debg creating role ft_default_space1_ml_all
[00:10:55]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [ft_default_space1_ml_all]
[00:10:55]             │ debg creating role ft_all_spaces_ml_all
[00:10:55]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [ft_all_spaces_ml_all]
[00:10:55]             │ debg creating role ft_default_space_ml_read
[00:10:55]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [ft_default_space_ml_read]
[00:10:55]             │ debg creating role ft_default_space1_ml_read
[00:10:55]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [ft_default_space1_ml_read]
[00:10:55]             │ debg creating role ft_all_spaces_ml_read
[00:10:55]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [ft_all_spaces_ml_read]
[00:10:55]             │ debg creating role ft_default_space_ml_none
[00:10:55]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [ft_default_space_ml_none]
[00:10:55]             │ debg creating user ft_ml_poweruser
[00:10:56]             │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [ft_ml_poweruser]
[00:10:56]             │ debg created user ft_ml_poweruser
[00:10:56]             │ debg creating user ft_ml_poweruser_spaces
[00:10:56]             │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [ft_ml_poweruser_spaces]
[00:10:56]             │ debg created user ft_ml_poweruser_spaces
[00:10:56]             │ debg creating user ft_ml_poweruser_space1
[00:10:56]             │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [ft_ml_poweruser_space1]
[00:10:56]             │ debg created user ft_ml_poweruser_space1
[00:10:56]             │ debg creating user ft_ml_poweruser_all_spaces
[00:10:56]             │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [ft_ml_poweruser_all_spaces]
[00:10:56]             │ debg created user ft_ml_poweruser_all_spaces
[00:10:56]             │ debg creating user ft_ml_viewer
[00:10:56]             │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [ft_ml_viewer]
[00:10:56]             │ debg created user ft_ml_viewer
[00:10:56]             │ debg creating user ft_ml_viewer_spaces
[00:10:56]             │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [ft_ml_viewer_spaces]
[00:10:56]             │ debg created user ft_ml_viewer_spaces
[00:10:56]             │ debg creating user ft_ml_viewer_space1
[00:10:56]             │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [ft_ml_viewer_space1]
[00:10:56]             │ debg created user ft_ml_viewer_space1
[00:10:56]             │ debg creating user ft_ml_viewer_all_spaces
[00:10:56]             │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [ft_ml_viewer_all_spaces]
[00:10:56]             │ debg created user ft_ml_viewer_all_spaces
[00:10:56]             │ debg creating user ft_ml_unauthorized
[00:10:57]             │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [ft_ml_unauthorized]
[00:10:57]             │ debg created user ft_ml_unauthorized
[00:10:57]             │ debg creating user ft_ml_unauthorized_spaces
[00:10:57]             │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [ft_ml_unauthorized_spaces]
[00:10:57]             │ debg created user ft_ml_unauthorized_spaces
[00:15:00]           └-: jobs
[00:15:00]             └-> "before all" hook in "jobs"
[00:15:00]             └-: Categorization example endpoint - 
[00:15:00]               └-> "before all" hook for "valid with good number of tokens"
[00:15:00]               └-> "before all" hook for "valid with good number of tokens"
[00:15:00]                 │ info [x-pack/test/functional/es_archives/ml/categorization] Loading "mappings.json"
[00:15:00]                 │ info [x-pack/test/functional/es_archives/ml/categorization] Loading "data.json.gz"
[00:15:00]                 │ info [o.e.c.m.MetadataCreateIndexService] [node-01] [ft_categorization] creating index, cause [api], templates [], shards [1]/[0]
[00:15:00]                 │ info [x-pack/test/functional/es_archives/ml/categorization] Created index "ft_categorization"
[00:15:00]                 │ debg [x-pack/test/functional/es_archives/ml/categorization] "ft_categorization" settings {"index":{"number_of_replicas":"0","number_of_shards":"1"}}
[00:15:01]                 │ info [x-pack/test/functional/es_archives/ml/categorization] Indexed 1501 docs into "ft_categorization"
[00:15:01]                 │ debg applying update to kibana config: {"dateFormat:tz":"UTC"}
[00:15:02]               └-> valid with good number of tokens
[00:15:02]                 └-> "before each" hook: global before each for "valid with good number of tokens"
[00:15:02]                 └- ✓ pass  (147ms)
[00:15:02]               └-> invalid, too many tokens.
[00:15:02]                 └-> "before each" hook: global before each for "invalid, too many tokens."
[00:15:02]                 │ info [r.suppressed] [node-01] path: /_analyze, params: {}
[00:15:02]                 │      org.elasticsearch.transport.RemoteTransportException: [node-01][127.0.0.1:63111][indices:admin/analyze[s]]
[00:15:02]                 │      Caused by: java.lang.IllegalStateException: The number of tokens produced by calling _analyze has exceeded the allowed maximum of [10000]. This limit can be set by changing the [index.analyze.max_token_count] index level setting.
[00:15:02]                 │      	at org.elasticsearch.action.admin.indices.analyze.TransportAnalyzeAction$TokenCounter.increment(TransportAnalyzeAction.java:397) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:15:02]                 │      	at org.elasticsearch.action.admin.indices.analyze.TransportAnalyzeAction.simpleAnalyze(TransportAnalyzeAction.java:229) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:15:02]                 │      	at org.elasticsearch.action.admin.indices.analyze.TransportAnalyzeAction.analyze(TransportAnalyzeAction.java:204) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:15:02]                 │      	at org.elasticsearch.action.admin.indices.analyze.TransportAnalyzeAction.analyze(TransportAnalyzeAction.java:122) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:15:02]                 │      	at org.elasticsearch.action.admin.indices.analyze.TransportAnalyzeAction.shardOperation(TransportAnalyzeAction.java:110) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:15:02]                 │      	at org.elasticsearch.action.admin.indices.analyze.TransportAnalyzeAction.shardOperation(TransportAnalyzeAction.java:62) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:15:02]                 │      	at org.elasticsearch.action.support.single.shard.TransportSingleShardAction.lambda$asyncShardOperation$0(TransportSingleShardAction.java:99) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:15:02]                 │      	at org.elasticsearch.action.ActionRunnable.lambda$supply$0(ActionRunnable.java:47) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:15:02]                 │      	at org.elasticsearch.action.ActionRunnable$2.doRun(ActionRunnable.java:62) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:15:02]                 │      	at org.elasticsearch.common.util.concurrent.ThreadContext$ContextPreservingAbstractRunnable.doRun(ThreadContext.java:737) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:15:02]                 │      	at org.elasticsearch.common.util.concurrent.AbstractRunnable.run(AbstractRunnable.java:26) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:15:02]                 │      	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) [?:?]
[00:15:02]                 │      	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) [?:?]
[00:15:02]                 │      	at java.lang.Thread.run(Thread.java:833) [?:?]
[00:15:03]                 └- ✖ fail: apis Machine Learning jobs Categorization example endpoint -  invalid, too many tokens.
[00:15:03]                 │       Error: expected 'partially_valid' to sort of equal 'invalid'
[00:15:03]                 │       + expected - actual
[00:15:03]                 │ 
[00:15:03]                 │       -partially_valid
[00:15:03]                 │       +invalid
[00:15:03]                 │       
[00:15:03]                 │       at Assertion.assert (/dev/shm/workspace/parallel/11/kibana/node_modules/@kbn/expect/expect.js:100:11)
[00:15:03]                 │       at Assertion.eql (/dev/shm/workspace/parallel/11/kibana/node_modules/@kbn/expect/expect.js:244:8)
[00:15:03]                 │       at Context.<anonymous> (test/api_integration/apis/ml/jobs/categorization_field_examples.ts:302:44)
[00:15:03]                 │       at runMicrotasks (<anonymous>)
[00:15:03]                 │       at processTicksAndRejections (node:internal/process/task_queues:96:5)
[00:15:03]                 │       at Object.apply (/dev/shm/workspace/parallel/11/kibana/node_modules/@kbn/test/target_node/functional_test_runner/lib/mocha/wrap_function.js:87:16)
[00:15:03]                 │ 
[00:15:03]                 │

Stack Trace

Error: expected 'partially_valid' to sort of equal 'invalid'
    at Assertion.assert (/dev/shm/workspace/parallel/11/kibana/node_modules/@kbn/expect/expect.js:100:11)
    at Assertion.eql (/dev/shm/workspace/parallel/11/kibana/node_modules/@kbn/expect/expect.js:244:8)
    at Context.<anonymous> (test/api_integration/apis/ml/jobs/categorization_field_examples.ts:302:44)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at Object.apply (/dev/shm/workspace/parallel/11/kibana/node_modules/@kbn/test/target_node/functional_test_runner/lib/mocha/wrap_function.js:87:16) {
  actual: 'partially_valid',
  expected: 'invalid',
  showDiff: true
}

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`console`	9	13	+4
`rollup`	20	21	+1
`snapshotRestore`	22	23	+1
total			+6

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`home`	81.7KB	81.7KB	+12.0B
`inspector`	14.8KB	14.8KB	+14.0B
`upgradeAssistant`	104.3KB	104.3KB	-32.0B
total			-6.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`console`	16.6KB	16.6KB	+89.0B
`indexManagement`	36.4KB	36.4KB	+49.0B
`licenseManagement`	11.1KB	11.2KB	+56.0B
`rollup`	11.7KB	11.8KB	+82.0B
`snapshotRestore`	29.0KB	29.1KB	+31.0B
`upgradeAssistant`	18.9KB	18.9KB	+28.0B
total			+335.0B

Unknown metric groups

API count

id	before	after	diff
`console`	9	13	+4
`rollup`	20	21	+1
`snapshotRestore`	22	23	+1
total			+6

History

💛 Build #162455 was flaky d5e7e16
💔 Build #162391 failed 223d956
💔 Build #162324 failed 596c605
💚 Build #162080 succeeded 83e0a7b
💔 Build #162056 failed 52739f8

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…4768) (#115541) * [Stack management apps] Deprecate "enabled" Kibana setting (#114768) # Conflicts: # docs/dev-tools/console/console.asciidoc # docs/setup/settings.asciidoc # x-pack/plugins/upgrade_assistant/__jest__/client_integration/helpers/index.ts # x-pack/plugins/upgrade_assistant/__jest__/client_integration/helpers/setup_environment.tsx # x-pack/plugins/upgrade_assistant/__jest__/client_integration/overview/overview.test.tsx # x-pack/plugins/upgrade_assistant/common/config.ts # x-pack/plugins/upgrade_assistant/common/constants.ts # x-pack/plugins/upgrade_assistant/public/application/components/es_deprecations/deprecation_types/reindex/flyout/warning_step.test.tsx # x-pack/plugins/upgrade_assistant/public/plugin.ts # x-pack/plugins/upgrade_assistant/public/types.ts * Fix doc issue * [CCR] Update "MAJOR_VERSION" constant * [ILM] Update "MAJOR_VERSION" constant * [License Management] Update "MAJOR_VERSION" constant * [Remote Clusters] Update "MAJOR_VERSION" constant * [Rollup] Update "MAJOR_VERSION" constant * [S&R] Update "MAJOR_VERSION" constant * [UA] Update "MAJOR_VERSION" constant * Fix default value for "readonly" in 7.16.0

sebelga commented Oct 13, 2021

View reviewed changes

sebelga added 15 commits October 14, 2021 14:11

[Index management] Add ui.enabled kibana setting

4ec0c8b

[Rolllup Add ui.enabled kibana setting

8cfa25e

[Snapshot and restore] Add ui.enabled kibana setting

d58fd9c

[UA] Align with other apps and use the "MAJOR_VERSION" constant

d93ca8c

[UA] Align with other apps and use the "MAJOR_VERSION" constant (2)

25bc566

[UA] Add ui.enabled kibana setting

c7ac361

[Console] Add ui.enabled kibana setting

ed42009

Fix TS and i18n issues

020bbd7

[CCR] Add ui.enabled kibana setting

cc60f00

[ILM] Add deprecation for "enabled" setting

5fe7713

[License management] Add deprecation for "enabled" setting

cf46649

Fix i18n issue

8f936a6

Fix jest test

d8b6909

[Remote clusters] Add deprecation for "enabled" setting

63df99c

Fix i18n issue

338488a

sebelga force-pushed the stack-managment-apps-deprecate-enable branch from e53f549 to 338488a Compare October 14, 2021 13:13

sebelga marked this pull request as ready for review October 14, 2021 13:13

sebelga requested review from a team as code owners October 14, 2021 13:13

sebelga requested review from cjcenizal, sabarasaba and yuliacech October 14, 2021 13:14

sebelga added release_note:breaking Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.16.0 v8.0.0 labels Oct 14, 2021

sebelga removed the release_note:breaking label Oct 14, 2021

Merge branch 'master' into stack-managment-apps-deprecate-enable

90f3227

sebelga added 3 commits October 18, 2021 14:22

Improve deprecation message for console.proxyConfig and console.proxy…

6813c6a

…Filter (fixes elastic#113810)

Merge branch 'stack-managment-apps-deprecate-enable' of github.com:se…

29bf4c7

…belga/kibana into stack-managment-apps-deprecate-enable

Fix TS issue

52739f8

Add doc for the "<app>.ui.enabled" setting

83e0a7b

Dosant approved these changes Oct 18, 2021

View reviewed changes

yuliacech approved these changes Oct 18, 2021

View reviewed changes

cjcenizal added 4 commits October 18, 2021 13:50

Fix Console deprecations.

183a1c3

* Fix copy * Configure level

Add inline comments where we check if Console UI is enabled.

2e326e5

* Clarify distinction between Dev Tools and Console.

Fix typo in docs.

61b703e

Configure level and refine copy for other deprecations.

596c605

cjcenizal force-pushed the stack-managment-apps-deprecate-enable branch from d5abd6f to 596c605 Compare October 18, 2021 20:55

cjcenizal approved these changes Oct 18, 2021

View reviewed changes

Merge branch 'master' into stack-managment-apps-deprecate-enable

223d956

Merge branch 'master' into stack-managment-apps-deprecate-enable

d5e7e16

sabarasaba approved these changes Oct 19, 2021

View reviewed changes

sebelga merged commit f6a9afe into elastic:master Oct 19, 2021

sebelga deleted the stack-managment-apps-deprecate-enable branch October 19, 2021 10:34

sebelga mentioned this pull request Oct 19, 2021

[7.x] [Stack management apps] Deprecate "enabled" Kibana setting (#114768) #115541

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Stack management apps] Deprecate "enabled" Kibana setting #114768

[Stack management apps] Deprecate "enabled" Kibana setting #114768

sebelga commented Oct 13, 2021 •

edited

Loading

sebelga Oct 13, 2021 •

edited

Loading

elasticmachine commented Oct 14, 2021

sebelga commented Oct 18, 2021

legrego commented Oct 18, 2021

sebelga commented Oct 18, 2021

sebelga commented Oct 18, 2021

sebelga commented Oct 18, 2021

Dosant left a comment

yuliacech left a comment

cjcenizal left a comment

cjcenizal commented Oct 18, 2021

cjcenizal commented Oct 19, 2021

sebelga commented Oct 19, 2021

kibanamachine commented Oct 19, 2021

Standard Out

Stack Trace

API count

[Stack management apps] Deprecate "enabled" Kibana setting #114768

[Stack management apps] Deprecate "enabled" Kibana setting #114768

Conversation

sebelga commented Oct 13, 2021 • edited Loading

Notes on implementation

How to test

Test Console

Improve console.proxyConfig and console.proxyFilter warning

sebelga Oct 13, 2021 • edited Loading

Choose a reason for hiding this comment

elasticmachine commented Oct 14, 2021

sebelga commented Oct 18, 2021

legrego commented Oct 18, 2021

sebelga commented Oct 18, 2021

sebelga commented Oct 18, 2021

sebelga commented Oct 18, 2021

Dosant left a comment

Choose a reason for hiding this comment

yuliacech left a comment

Choose a reason for hiding this comment

cjcenizal left a comment

Choose a reason for hiding this comment

cjcenizal commented Oct 18, 2021

cjcenizal commented Oct 19, 2021

sebelga commented Oct 19, 2021

kibanamachine commented Oct 19, 2021

💛 Build succeeded, but was flaky

Test Failures

Standard Out

Stack Trace

Metrics [docs]

Public APIs missing comments

Async chunks

Page load bundle

API count

History

sebelga commented Oct 13, 2021 •

edited

Loading

Improve console.proxyConfig and `console.proxyFilter` warning

sebelga Oct 13, 2021 •

edited

Loading