Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Stack Monitoring] fix beats pages test-subj attributes #114835

Merged
merged 2 commits into from
Oct 13, 2021

Conversation

klacabane
Copy link
Contributor

Summary

Fixes functional tests that rely on the test-subj attribute to target dom elements #114802

Testing

  • set render_react_app to true
  • start test server node scripts/functional_tests_server --config x-pack/test/functional/config.js
  • run tests node scripts/functional_test_runner --config x-pack/test/functional/config.js --grep "Monitoring app beats"
...
...
     └-> "after all" hook for "cluster status bar shows correct information"
     └-> "after all" hook for "cluster status bar shows correct information"
   └-> "after all" hook in "Monitoring app"

5 passing (2.0m)

@klacabane klacabane added Team:Monitoring Stack Monitoring team v8.0.0 Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services release_note:skip Skip the PR/issue when compiling release notes v7.16.0 Epic: Stack Monitoring de-angularization labels Oct 13, 2021
@klacabane klacabane requested a review from a team as a code owner October 13, 2021 15:29
@klacabane klacabane requested review from a team October 13, 2021 15:29
@elasticmachine
Copy link
Contributor

Pinging @elastic/stack-monitoring (Team:Monitoring)

@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
monitoring 1.1MB 1.1MB -50.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@klacabane klacabane merged commit 491fcd5 into elastic:master Oct 13, 2021
@klacabane klacabane deleted the fix-beats-func-tests branch October 13, 2021 19:45
matschaffer pushed a commit to matschaffer/kibana that referenced this pull request Oct 15, 2021
* fix beats pages test-subj attributes

* fix eslint errors
matschaffer added a commit that referenced this pull request Oct 15, 2021
…15138)

* fix beats pages test-subj attributes

* fix eslint errors

Co-authored-by: Kevin Lacabane <kevin.lacabane@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Epic: Stack Monitoring de-angularization release_note:skip Skip the PR/issue when compiling release notes Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services Team:Monitoring Stack Monitoring team v7.16.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants