Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [Index Management] Added data-test-subj values to the index context menu buttons (#114900) #114959

Merged
merged 9 commits into from
Oct 21, 2021
Merged

[7.x] [Index Management] Added data-test-subj values to the index context menu buttons (#114900) #114959

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
9678372
[Index Management] Added `data-test-subj` values to the index context…
yuliacech Oct 14, 2021
ad2512d
Merge branch '7.x' into backport/7.x/pr-114900
kibanamachine Oct 14, 2021
bc5f2d4
Fixed test as indices list is different in 7.x
yuliacech Oct 18, 2021
c3bf375
Merge branch '7.x' into backport/7.x/pr-114900
kibanamachine Oct 18, 2021
89a51fd
[Index Management] Fixed indices list test for 7.x
yuliacech Oct 20, 2021
31a703e
[Index Management] Fixed indices list test for 7.x
yuliacech Oct 20, 2021
d15e884
Merge branch '7.x' into backport/7.x/pr-114900
kibanamachine Oct 20, 2021
9c12241
Merge branch '7.x' into backport/7.x/pr-114900
kibanamachine Oct 20, 2021
fbfd6a8
Merge branch '7.16' into backport/7.x/pr-114900
kibanamachine Oct 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion x-pack/plugins/index_management/__jest__/components/__snapshots__/index_table.test.js.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

79 changes: 42 additions & 37 deletions x-pack/plugins/index_management/__jest__/components/index_table.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,15 @@ const snapshot = (rendered) => {
expect(rendered).toMatchSnapshot();
};

const openMenuAndClickButton = (rendered, rowIndex, buttonIndex) => {
const names = (rendered) => {
return findTestSubject(rendered, 'indexTableIndexNameLink');
};

const namesText = (rendered) => {
return names(rendered).map((button) => button.text());
};

const openMenuAndClickButton = (rendered, rowIndex, buttonSelector) => {
// Select a row.
const checkboxes = findTestSubject(rendered, 'indexTableRowCheckbox');
checkboxes.at(rowIndex).simulate('change', { target: { checked: true } });
Expand All @@ -100,18 +108,19 @@ const openMenuAndClickButton = (rendered, rowIndex, buttonIndex) => {
rendered.update();

// Click an action in the context menu.
const contextMenuButtons = findTestSubject(rendered, 'indexTableContextMenuButton');
contextMenuButtons.at(buttonIndex).simulate('click');
const contextMenuButton = findTestSubject(rendered, buttonSelector);
contextMenuButton.simulate('click');
rendered.update();
};

const testEditor = (rendered, buttonIndex, rowIndex = 0) => {
openMenuAndClickButton(rendered, rowIndex, buttonIndex);
const testEditor = (rendered, buttonSelector, rowIndex = 0) => {
openMenuAndClickButton(rendered, rowIndex, buttonSelector);
rendered.update();
snapshot(findTestSubject(rendered, 'detailPanelTabSelected').text());
};

const testAction = (rendered, buttonIndex, rowIndex = 0) => {
const testAction = (rendered, buttonSelector, indexName = 'testy0') => {
const rowIndex = namesText(rendered).indexOf(indexName);
// This is leaking some implementation details about how Redux works. Not sure exactly what's going on
// but it looks like we're aware of how many Redux actions are dispatched in response to user interaction,
// so we "time" our assertion based on how many Redux actions we observe. This is brittle because it
Expand All @@ -127,19 +136,16 @@ const testAction = (rendered, buttonIndex, rowIndex = 0) => {
dispatchedActionsCount++;
});

openMenuAndClickButton(rendered, rowIndex, buttonIndex);
openMenuAndClickButton(rendered, rowIndex, buttonSelector);
// take snapshot of initial state.
snapshot(status(rendered, rowIndex));
};

const names = (rendered) => {
return findTestSubject(rendered, 'indexTableIndexNameLink');
};

const namesText = (rendered) => {
return names(rendered).map((button) => button.text());
const getActionMenuButtons = (rendered) => {
return findTestSubject(rendered, 'indexContextMenu')
.find('button')
.map((span) => span.text());
};

describe('index table', () => {
beforeEach(() => {
// Mock initialization of services
Expand Down Expand Up @@ -232,7 +238,7 @@ describe('index table', () => {
await runAllPromises();
rendered.update();

let button = findTestSubject(rendered, 'indexTableContextMenuButton');
let button = findTestSubject(rendered, 'indexActionsContextMenuButton');
expect(button.length).toEqual(0);

const checkboxes = findTestSubject(rendered, 'indexTableRowCheckbox');
Expand All @@ -247,7 +253,7 @@ describe('index table', () => {
await runAllPromises();
rendered.update();

let button = findTestSubject(rendered, 'indexTableContextMenuButton');
let button = findTestSubject(rendered, 'indexActionsContextMenuButton');
expect(button.length).toEqual(0);

const checkboxes = findTestSubject(rendered, 'indexTableRowCheckbox');
Expand Down Expand Up @@ -353,7 +359,7 @@ describe('index table', () => {
const actionButton = findTestSubject(rendered, 'indexActionsContextMenuButton');
actionButton.simulate('click');
rendered.update();
snapshot(findTestSubject(rendered, 'indexTableContextMenuButton').map((span) => span.text()));
snapshot(getActionMenuButtons(rendered));
});

test('should show the right context menu options when one index is selected and closed', async () => {
Expand All @@ -367,7 +373,7 @@ describe('index table', () => {
const actionButton = findTestSubject(rendered, 'indexActionsContextMenuButton');
actionButton.simulate('click');
rendered.update();
snapshot(findTestSubject(rendered, 'indexTableContextMenuButton').map((span) => span.text()));
snapshot(getActionMenuButtons(rendered));
});

test('should show the right context menu options when one open and one closed index is selected', async () => {
Expand All @@ -382,7 +388,7 @@ describe('index table', () => {
const actionButton = findTestSubject(rendered, 'indexActionsContextMenuButton');
actionButton.simulate('click');
rendered.update();
snapshot(findTestSubject(rendered, 'indexTableContextMenuButton').map((span) => span.text()));
snapshot(getActionMenuButtons(rendered));
});

test('should show the right context menu options when more than one open index is selected', async () => {
Expand All @@ -397,7 +403,7 @@ describe('index table', () => {
const actionButton = findTestSubject(rendered, 'indexActionsContextMenuButton');
actionButton.simulate('click');
rendered.update();
snapshot(findTestSubject(rendered, 'indexTableContextMenuButton').map((span) => span.text()));
snapshot(getActionMenuButtons(rendered));
});

test('should show the right context menu options when more than one closed index is selected', async () => {
Expand All @@ -412,28 +418,28 @@ describe('index table', () => {
const actionButton = findTestSubject(rendered, 'indexActionsContextMenuButton');
actionButton.simulate('click');
rendered.update();
snapshot(findTestSubject(rendered, 'indexTableContextMenuButton').map((span) => span.text()));
snapshot(getActionMenuButtons(rendered));
});

test('flush button works from context menu', async () => {
const rendered = mountWithIntl(component);
await runAllPromises();
rendered.update();
testAction(rendered, 8);
testAction(rendered, 'flushIndexMenuButton');
});

test('clear cache button works from context menu', async () => {
const rendered = mountWithIntl(component);
await runAllPromises();
rendered.update();
testAction(rendered, 7);
testAction(rendered, 'clearCacheIndexMenuButton');
});

test('refresh button works from context menu', async () => {
const rendered = mountWithIntl(component);
await runAllPromises();
rendered.update();
testAction(rendered, 6);
testAction(rendered, 'refreshIndexMenuButton');
});

test('force merge button works from context menu', async () => {
Expand All @@ -442,7 +448,7 @@ describe('index table', () => {
rendered.update();

const rowIndex = 0;
openMenuAndClickButton(rendered, rowIndex, 5);
openMenuAndClickButton(rendered, rowIndex, 'forcemergeIndexMenuButton');
snapshot(status(rendered, rowIndex));
expect(rendered.find('.euiModal').length).toBe(1);

Expand Down Expand Up @@ -478,55 +484,54 @@ describe('index table', () => {
JSON.stringify(modifiedIndices),
]);

testAction(rendered, 4);
testAction(rendered, 'closeIndexMenuButton');
});

test('open index button works from context menu', async () => {
const rendered = mountWithIntl(component);
await runAllPromises();
rendered.update();

const modifiedIndices = indices.map((index) => {
return {
...index,
status: index.name === 'testy1' ? 'open' : index.status,
status: index.name === 'testy1' ? 'closed' : index.status,
};
});

server.respondWith(`${API_BASE_PATH}/indices/reload`, [
server.respondWith(`${API_BASE_PATH}/indices`, [
200,
{ 'Content-Type': 'application/json' },
JSON.stringify(modifiedIndices),
]);

testAction(rendered, 3, 1);
const rendered = mountWithIntl(component);
await runAllPromises();
rendered.update();
testAction(rendered, 'openIndexMenuButton', 'testy1');
});

test('show settings button works from context menu', async () => {
const rendered = mountWithIntl(component);
await runAllPromises();
rendered.update();
testEditor(rendered, 0);
testEditor(rendered, 'showSettingsIndexMenuButton');
});

test('show mappings button works from context menu', async () => {
const rendered = mountWithIntl(component);
await runAllPromises();
rendered.update();
testEditor(rendered, 1);
testEditor(rendered, 'showMappingsIndexMenuButton');
});

test('show stats button works from context menu', async () => {
const rendered = mountWithIntl(component);
await runAllPromises();
rendered.update();
testEditor(rendered, 2);
testEditor(rendered, 'showStatsIndexMenuButton');
});

test('edit index button works from context menu', async () => {
const rendered = mountWithIntl(component);
await runAllPromises();
rendered.update();
testEditor(rendered, 3);
testEditor(rendered, 'editIndexMenuButton');
});
});
19 changes: 15 additions & 4 deletions ...ication/sections/home/index_list/index_actions_context_menu/index_actions_context_menu.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@ export class IndexActionsContextMenu extends Component {
const items = [];
if (!detailPanel && selectedIndexCount === 1) {
items.push({
'data-test-subj': 'showSettingsIndexMenuButton',
name: i18n.translate('xpack.idxMgmt.indexActionsMenu.showIndexSettingsLabel', {
defaultMessage:
'Show {selectedIndexCount, plural, one {index} other {indices} } settings',
Expand All @@ -85,6 +86,7 @@ export class IndexActionsContextMenu extends Component {
},
});
items.push({
'data-test-subj': 'showMappingsIndexMenuButton',
name: i18n.translate('xpack.idxMgmt.indexActionsMenu.showIndexMappingLabel', {
defaultMessage: 'Show {selectedIndexCount, plural, one {index} other {indices} } mapping',
values: { selectedIndexCount },
Expand All @@ -95,6 +97,7 @@ export class IndexActionsContextMenu extends Component {
});
if (allOpen) {
items.push({
'data-test-subj': 'showStatsIndexMenuButton',
name: i18n.translate('xpack.idxMgmt.indexActionsMenu.showIndexStatsLabel', {
defaultMessage: 'Show {selectedIndexCount, plural, one {index} other {indices} } stats',
values: { selectedIndexCount },
Expand All @@ -105,6 +108,7 @@ export class IndexActionsContextMenu extends Component {
});
}
items.push({
'data-test-subj': 'editIndexMenuButton',
name: i18n.translate('xpack.idxMgmt.indexActionsMenu.editIndexSettingsLabel', {
defaultMessage:
'Edit {selectedIndexCount, plural, one {index} other {indices} } settings',
Expand All @@ -117,6 +121,7 @@ export class IndexActionsContextMenu extends Component {
}
if (allOpen) {
items.push({
'data-test-subj': 'closeIndexMenuButton',
name: i18n.translate('xpack.idxMgmt.indexActionsMenu.closeIndexLabel', {
defaultMessage: 'Close {selectedIndexCount, plural, one {index} other {indices} }',
values: { selectedIndexCount },
Expand All @@ -131,6 +136,7 @@ export class IndexActionsContextMenu extends Component {
},
});
items.push({
'data-test-subj': 'forcemergeIndexMenuButton',
name: i18n.translate('xpack.idxMgmt.indexActionsMenu.forceMergeIndexLabel', {
defaultMessage: 'Force merge {selectedIndexCount, plural, one {index} other {indices} }',
values: { selectedIndexCount },
Expand All @@ -141,6 +147,7 @@ export class IndexActionsContextMenu extends Component {
},
});
items.push({
'data-test-subj': 'refreshIndexMenuButton',
name: i18n.translate('xpack.idxMgmt.indexActionsMenu.refreshIndexLabel', {
defaultMessage: 'Refresh {selectedIndexCount, plural, one {index} other {indices} }',
values: { selectedIndexCount },
Expand All @@ -150,6 +157,7 @@ export class IndexActionsContextMenu extends Component {
},
});
items.push({
'data-test-subj': 'clearCacheIndexMenuButton',
name: i18n.translate('xpack.idxMgmt.indexActionsMenu.clearIndexCacheLabel', {
defaultMessage: 'Clear {selectedIndexCount, plural, one {index} other {indices} } cache',
values: { selectedIndexCount },
Expand All @@ -159,6 +167,7 @@ export class IndexActionsContextMenu extends Component {
},
});
items.push({
'data-test-subj': 'flushIndexMenuButton',
name: i18n.translate('xpack.idxMgmt.indexActionsMenu.flushIndexLabel', {
defaultMessage: 'Flush {selectedIndexCount, plural, one {index} other {indices} }',
values: { selectedIndexCount },
Expand Down Expand Up @@ -191,6 +200,7 @@ export class IndexActionsContextMenu extends Component {
}
} else {
items.push({
'data-test-subj': 'openIndexMenuButton',
name: i18n.translate('xpack.idxMgmt.indexActionsMenu.openIndexLabel', {
defaultMessage: 'Open {selectedIndexCount, plural, one {index} other {indices} }',
values: { selectedIndexCount },
Expand Down Expand Up @@ -239,9 +249,6 @@ export class IndexActionsContextMenu extends Component {
}
}
});
items.forEach((item) => {
item['data-test-subj'] = 'indexTableContextMenuButton';
});
const panelTree = {
id: 0,
title: i18n.translate('xpack.idxMgmt.indexActionsMenu.panelTitle', {
Expand Down Expand Up @@ -732,7 +739,11 @@ export class IndexActionsContextMenu extends Component {
anchorPosition={anchorPosition}
repositionOnScroll
>
<EuiContextMenu initialPanelId={0} panels={panels} />
<EuiContextMenu
initialPanelId={0}
panels={panels}
data-test-subj="indexContextMenu"
/>
</EuiPopover>
</div>
);
Expand Down