Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve session timeout deprecation messages. #115020

Merged
merged 8 commits into from
Oct 19, 2021
Merged

Improve session timeout deprecation messages. #115020

merged 8 commits into from
Oct 19, 2021

Conversation

azasypkin
Copy link
Member

@azasypkin azasypkin commented Oct 14, 2021 •
edited
Loading

Summary

Improve session timeout deprecation messages.

Context: #106061 (comment). After a Slack discussion with @gchaps we decided that a documentation link isn't that useful and all required information can be included in the deprecation detailed view instead.

Screenshots

  1. Main UA list view

screen_1

  1. Detailed view for the first deprecation

screen_2

  1. Detailed view for the second deprecation

screen_2

@azasypkin azasypkin added deprecation_warnings release_note:skip Skip the PR/issue when compiling release notes Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! v7.16.0 labels Oct 14, 2021
@azasypkin azasypkin marked this pull request as ready for review October 14, 2021 16:58
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

@azasypkin azasypkin requested a review from gchaps October 14, 2021 16:58
@jportner jportner mentioned this pull request Oct 14, 2021
Closed
gchaps
gchaps approved these changes Oct 14, 2021
View reviewed changes
Copy link
Contributor

@gchaps gchaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a minor nit. Is it possible to keep [ms|s|m|h|d|w|M|Y] all on the same line?

@azasypkin
Copy link
Member Author

azasypkin commented Oct 15, 2021 •
edited
Loading

LGTM with a minor nit. Is it possible to keep [ms|s|m|h|d|w|M|Y] all on the same line?

The only way I could think of is to use a Word Joiner (U+2060) after <count>. It seems to do the job, I've updated screenshots and also left a note for our translation team to preserve the Word Joiner in translations.

@azasypkin azasypkin requested a review from jportner October 15, 2021 11:58
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

This was referenced Oct 19, 2021
Merged
Merged
jportner
jportner approved these changes Oct 19, 2021
View reviewed changes
Copy link
Contributor

@jportner jportner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@azasypkin azasypkin enabled auto-merge (squash) October 19, 2021 16:39
@azasypkin azasypkin merged commit 63b9762 into elastic:7.x Oct 19, 2021
@kibanamachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@azasypkin azasypkin deleted the issue-xxx-session-deprecations branch October 19, 2021 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gchaps gchaps gchaps approved these changes

@jportner jportner jportner approved these changes

Assignees
No one assigned
Labels
buildkite-ci deprecation_warnings release_note:skip Skip the PR/issue when compiling release notes Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! v7.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@azasypkin @elasticmachine @kibanamachine @jportner @gchaps