-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preserves originating path when returning from editor #115118
Conversation
49da448
to
5a00375
Compare
2030a15
to
afea023
Compare
9b7ee32
to
75747b7
Compare
afea023
to
6b2bc48
Compare
75747b7
to
3582490
Compare
6b2bc48
to
196b94d
Compare
3582490
to
356c4e7
Compare
f8dbcaf
to
34831c5
Compare
356c4e7
to
a7c6904
Compare
💔 Build Failed
Failed CI StepsTest FailuresJest Tests.src/plugins/embeddable/public/lib/actions.redirects to app using state transfer with by value modeStandard Out
Stack Trace
Jest Tests.src/plugins/embeddable/public/lib/actions.redirects to app using state transfer without by value modeStandard Out
Stack Trace
History
To update your PR or re-run it, just comment with: |
34831c5
to
6a29232
Compare
76a089d
to
da13e38
Compare
6a29232
to
8ac6d41
Compare
da13e38
to
20e7590
Compare
Pinging @elastic/kibana-presentation (Team:Presentation) |
20e7590
to
6a80a1e
Compare
796b0f5
to
9f946cf
Compare
@elasticmachine merge upstream |
@elastic/kibana-vis-editors Can I get a review on this PR? |
@elasticmachine merge upstream |
Support originatingPath in embeddable state transfer Fix ts error
73de89a
to
c20a6f3
Compare
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good! Kibana Vis Editors changes LGTM! I tested it locally as you proposed, it works fine!
…o canvas/fix-return-path
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
* Add originatingPath to edit_panel_action Support originatingPath in embeddable state transfer Fix ts error * Fixed jest tests * Parse originatingPath without using hash * provide static container context on embeddable panel * Fixed ts error Co-authored-by: Anton Dosov <anton.dosov@elastic.co> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
) * Add originatingPath to edit_panel_action Support originatingPath in embeddable state transfer Fix ts error * Fixed jest tests * Parse originatingPath without using hash * provide static container context on embeddable panel * Fixed ts error Co-authored-by: Anton Dosov <anton.dosov@elastic.co> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Catherine Liu <catherine.liu@elastic.co> Co-authored-by: Anton Dosov <anton.dosov@elastic.co>
* Add originatingPath to edit_panel_action Support originatingPath in embeddable state transfer Fix ts error * Fixed jest tests * Parse originatingPath without using hash * provide static container context on embeddable panel * Fixed ts error Co-authored-by: Anton Dosov <anton.dosov@elastic.co> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Summary
This fixes a bug where you lose your url parameters for your workpad after editing and saving your embeddable in an editor outside of Canvas and returning to your workpad.
In the
embeddable
plugin, I addedcontainerContext
which containsgetOriginatingPath
which allows presentation apps like Dashboard and Canvas to pass a function that returns the original path for the editor to return to.In the
maps
andvisualize
plugins, I extractedoriginatingPath
from the state transfer incoming editor state and path it through to where the app returns to the originating app.One way to test:
View
>Autoplay settings
and select30 seconds
. Notice: the url should have theautoplayInterval
param.Save and return
.autoplayInterval
param.Checklist
Delete any items that are not applicable to this PR.
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers