Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unskip kibana overview a11y test in xpack and adding the missing a11y painless lab test to config #115240

Merged
merged 4 commits into from
Oct 21, 2021

Conversation

bhavyarm
Copy link
Contributor

Trying close this skipped test issue - #98463
Also found out painless_lab.ts was missing from the config. Adding it in. Passes in my local.

@bhavyarm bhavyarm self-assigned this Oct 15, 2021
@bhavyarm bhavyarm added v8.0.0 Project:Accessibility release_note:skip Skip the PR/issue when compiling release notes Feature:Home Kibana home application labels Oct 15, 2021
@bhavyarm
Copy link
Contributor Author

@elasticmachine merge upstream

@bhavyarm bhavyarm added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:QA Team label for QA Team labels Oct 15, 2021
@bhavyarm
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @bhavyarm

@bhavyarm
Copy link
Contributor Author

@elasticmachine merge upstream

@bhavyarm bhavyarm marked this pull request as ready for review October 21, 2021 14:06
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-qa (Team:QA)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-accessibility (Project:Accessibility)

@bhavyarm
Copy link
Contributor Author

@bhavyarm bhavyarm requested a review from LeeDr October 21, 2021 16:20
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @bhavyarm

@bhavyarm bhavyarm requested a review from dmlemeshko October 21, 2021 17:06
Copy link
Member

@dmlemeshko dmlemeshko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. Let's give it a try

@bhavyarm bhavyarm merged commit 8bee1b8 into elastic:master Oct 21, 2021
bhavyarm added a commit to bhavyarm/kibana that referenced this pull request Oct 21, 2021
bhavyarm added a commit that referenced this pull request Oct 21, 2021
shivindera pushed a commit to shivindera/kibana that referenced this pull request Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Home Kibana home application impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Project:Accessibility release_note:skip Skip the PR/issue when compiling release notes Team:QA Team label for QA Team v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants