-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update elastic-charts to 38.0.1 #115623
update elastic-charts to 38.0.1 #115623
Conversation
@elasticmachine run elasticsearch-ci/docs |
'2015-09-20 00:00', | ||
'2015-09-21 00:00', | ||
'2015-09-22 00:00', | ||
'2015-09-23 00:00', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't tested it locally but why do we have these changes in the functional tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We changed the tick generation logic to have a semi-fix for #108260 in elastic/elastic-charts#1420. @monfera might have a better explanation as to what the reason is for the change.
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / general / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/ml/data_frame_analytics/feature_importance·ts.machine learning data frame analytics total feature importance panel and decision path popover multi class classification job should display the feature importance decision path in the data gridStandard Out
Stack Trace
Metrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
@elastic/kibana-data-discovery could you take a look at this please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review only, Data Discovery changes LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! We can also close this #111938 (I have already linked this to the issue). I tested it locally and now it scrolls correctly 🎉
I also tested the 'allowBrushingLasthistogrambin' and it works as before.
Ah yes thanks @stratoula I forgot about #111938. |
Summary
Closes #111938
Updates
@elastic/charts
to38.0.1
.Checklist